Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knative Test Cases Rearrangement #7081

Merged
merged 1 commit into from Nov 4, 2020
Merged

Knative Test Cases Rearrangement #7081

merged 1 commit into from Nov 4, 2020

Conversation

gajanan-more
Copy link
Contributor

@gajanan-more gajanan-more commented Nov 3, 2020 •
edited

Fixes: https://issues.redhat.com/browse/ODC-5073

Problem: Gherkin Scripts Rearrangement for Knative

Solution: We have created multiple feature files as per 4.6 epics for Knative. Let's rearrange and make the repo clean.

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Nov 3, 2020
makambalaji
makambalaji suggested changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove @debug and modify the @regression-1 to @regression where ever applicable in this entire pr

...d/packages/dev-console/integration-tests/features/Knative/actions-on-knative-service.feature Outdated Show resolved Hide resolved
...d/packages/dev-console/integration-tests/features/Knative/actions-on-knative-service.feature Outdated Show resolved Hide resolved
...d/packages/dev-console/integration-tests/features/Knative/actions-on-knative-service.feature Outdated Show resolved Hide resolved
...d/packages/dev-console/integration-tests/features/Knative/actions-on-knative-service.feature Outdated Show resolved Hide resolved
@makambalaji
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8447fbc into openshift:master Nov 4, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makambalaji makambalaji makambalaji requested changes

@rottencandy rottencandy Awaiting requested review from rottencandy

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@makambalaji makambalaji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gajanan-more @makambalaji @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot