Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IMV details page #7104

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Update IMV details page #7104

merged 1 commit into from
Nov 20, 2020

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Nov 4, 2020 •
edited
Loading

Fixes:
https://issues.redhat.com/browse/ODC-4997

Description:
Update IMV details page

  1. Add filters for vulnerabilities table
  2. Add column sorting in the vulnerabilities table.
  3. Add Manifest detail item.

Screen shots / Gifs for design review:
Screenshot 2020-11-17 at 4 34 04 PM
Screenshot 2020-11-17 at 4 34 25 PM
Screenshot 2020-11-17 at 4 34 41 PM
Screenshot 2020-11-17 at 4 35 05 PM

Unit test coverage report:
Screenshot 2020-11-17 at 4 42 19 PM

Test setup:
Install Quay Container Security operator

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Nov 4, 2020
@vikram-raj
Copy link
Member Author

/cc @invincibleJai @itsptk @openshift/team-devconsole-ux

@itsptk
Copy link

itsptk commented Nov 4, 2020

Looks great!

FYI @alecmerdler @dmesser

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2020
@vikram-raj
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@invincibleJai
Copy link
Member

@vikram-raj we may need to drop point 1 and 3 in description

@vikram-raj
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@spadgett spadgett removed their request for review November 16, 2020 15:06
@vikram-raj
Copy link
Member Author

@invincibleJai Removed the Type and Source column from the vulnerabilities table and removed the group toggle(App dependency and Base image) for vulnerabilities.

Quay Container Security operator has some issues in the installation. I will update the screenshots once it starts working.

@vikram-raj
Copy link
Member Author

@invincibleJai I updated the screenshots as well. PTAL. Thanks

@invincibleJai
Copy link
Member

/lgtm

Verified the changes works as expected

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@invincibleJai
Copy link
Member

/lgtm cancel

tests are failing

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@vikram-raj
Copy link
Member Author

@invincibleJai Fixed the tests. Thanks.

@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@vikram-raj
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e92878c into openshift:master Nov 20, 2020
@vikram-raj vikram-raj deleted the odc-4997 branch November 20, 2020 07:43
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@itsptk itsptk Awaiting requested review from itsptk

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

Assignees

@invincibleJai invincibleJai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.
9 participants
@vikram-raj @itsptk @invincibleJai @christianvogt @openshift-ci-robot @openshift-bot @karthikjeeyar @spadgett @openshift-merge-robot