Bug 1895065: Fix sample / snippet toggle in resource sidebar

[jerolimov]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1895065
and obsolete jira issue https://issues.redhat.com/browse/ODC-5091

Analysis / Root cause:
The yaml editor resource sidebar could not toggle between sample and snippets anymore after adding i18n support.

Sample and snippets was for example shown when creating or editing a pipeline yaml.

Solution Description:
Keep the translation in ResourceSidebar and keep SimpleTabNav "translation free".

Screen shots / Gifs for design review:

Unit test coverage report:
Not effected

Test setup:

1. Install the pipeline operator
2. Open the dev console and select Pipelines from the navigation
3. Click "Create Pipeline" and then "Edit YAML" in the top-right corner
4. If the sidebar is closed open it with "View sidebar"

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@jerolimov: This pull request references Bugzilla bug 1895065, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1895065: Keep translation in the SimpleTabNav usage component and fix sample/snippet toggle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/kind bug
/bugzilla refresh

[openshift-ci-robot]

@jerolimov: This pull request references Bugzilla bug 1895065, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/kind bug
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/lgtm

[spadgett]

ERROR in /go/src/github.com/openshift/console/frontend/public/components/sidebars/resource-sidebar.jsx
ERROR in /go/src/github.com/openshift/console/frontend/public/components/sidebars/resource-sidebar.jsx(90,13):
TS8010: Type annotations can only be used in TypeScript files.

/lgtm cancel

[spadgett]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#7125

Bugzilla bug 1895065 has been moved to the MODIFIED state.

In response to this:

Bug 1895065: Fix sample / snippet toggle in resource sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.