Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18n file diff test #7187

Merged
merged 1 commit into from Nov 16, 2020
Merged

Fix i18n file diff test #7187

merged 1 commit into from Nov 16, 2020

Conversation

rebeccaalpert
Copy link
Contributor

The diff test for i18n files was still using the old file location (./locales). I updated it to handle public and packages locales folders.

@rebeccaalpert rebeccaalpert changed the title Check for i18n file differences Fix i18n file diff test Nov 11, 2020
spadgett
spadgett reviewed Nov 11, 2020
View reviewed changes
test-frontend.sh Outdated Show resolved Hide resolved
spadgett
spadgett approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2020
@rebeccaalpert
Copy link
Contributor Author

Frontend test is going to fail until #7185 merges.

@spadgett
Copy link
Member

Looks like it's working :)

/hold until #7185 merges to fix the JSON files

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@rebeccaalpert
Copy link
Contributor Author

Rebasing.

@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Nov 11, 2020
@rebeccaalpert
Copy link
Contributor Author

Another JSON file came in; updated to see if frontend tests will now pass.

@rebeccaalpert
Copy link
Contributor Author

Another JSON file wasn't checked in.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Nov 11, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Nov 12, 2020
@rebeccaalpert rebeccaalpert force-pushed the fix-diff-test branch 4 times, most recently from 6f95f01 to 19b656a Compare November 12, 2020 17:35
@rebeccaalpert
Copy link
Contributor Author

One of the i18n files that hadn't been checked in was conflicting with a namespace in another package. I updated the namespace that was smaller to fix the e2e tests. Long term, we should have a tool to check for these. Can you review this @spadgett assuming tests now pass? Thanks.

spadgett
spadgett requested changes Nov 12, 2020
View reviewed changes
frontend/public/i18next-parser.config.js Outdated Show resolved Hide resolved
frontend/public/i18next-parser.config.js Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@rebeccaalpert
Copy link
Contributor Author

@spadgett - I updated file locations and imports; still have an open query on the support locales object.

@rebeccaalpert
Copy link
Contributor Author

/test e2e-gcp-console

@rebeccaalpert
Copy link
Contributor Author 

Failed Specs:
1) Modal Annotations : Delete Annotation
   StaleElementReferenceError: stale element reference: element is not attached to the page document

/retest

spadgett
spadgett reviewed Nov 13, 2020
View reviewed changes
frontend/i18next-parser.config.js Outdated Show resolved Hide resolved
frontend/public/components/modals/language-preferences-modal.tsx Show resolved Hide resolved
frontend/webpack.config.ts Outdated Show resolved Hide resolved
@rebeccaalpert rebeccaalpert force-pushed the fix-diff-test branch 2 times, most recently from 241784b to b654715 Compare November 13, 2020 20:12
@rebeccaalpert rebeccaalpert force-pushed the fix-diff-test branch 4 times, most recently from 14cd82f to de92287 Compare November 16, 2020 15:12
@rebeccaalpert
Check for i18n file differences
473ed7a 
Test was still using the old file location for i18n files. I updated it to handle public and packages.
spadgett
spadgett approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
This was referenced Nov 16, 2020
Merged
Merged
@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@spadgett
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 59360dc into openshift:master Nov 16, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rebeccaalpert @spadgett @openshift-ci-robot @openshift-bot @openshift-merge-robot