CONSOLE-2475: Check in Japanese and Chinese translations

[rebeccaalpert]

Adding first human translations for Japanese and Chinese from Terry's team.

There are only 123 JSON files in the first commit rather than 124 because the Japanese badge translations didn't differ from the prior machine translation. I confirmed the text matched.

The first commit reflects what was internationalized and present in master on November 4. The second commit is the Chinese translations for the remainder of Sprint 192. The third commit is the remaining Japanese translations for Sprint 192. Commit 4 is the revised translations in response to QE.

Fixes https://issues.redhat.com/browse/CONSOLE-2475.

[rebeccaalpert]

Blocked by #7187; need to add zh to language arrays/objects.

[rebeccaalpert]

Added Chinese to language selector and webpack config.

[spadgett]

/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888

[rebeccaalpert]

Rebased frontend/webpack.config.ts. Lost the lgtm.

[spadgett]

/lgtm

[ahardin-rh]

/label docs-approved

[spadgett]

ah ok I think I overlooked that email and was still waiting for a reply. While I think it's ok to just send the deltas, but if there are things that needs to be changed globally in keeping consistency across the UI, then having the entire set of files at early stage will be helpful. I think when we arrived to a stable stage for example maintenance phase, we can start receiving deltas-only. We have implemented some changes to the last set of files you sent me, do you want me to send those to you, or just wait for next drop to happen and we'll have the memory applied to them?

Cheers,
Terry

Hey, @rh-tchuang. If you have the changes ready, it would be great if you could send them. We aren't able to merge the PR until it has QE approval. I worry if we include a lot of new content each time QE will find additional things, and it will be hard to ever get the translations merged. Thanks!

[rh-tchuang]

Hi Rebecca, I'm attaching the strings here. Cheers, Terry Rebecca Alpert 於 3/12/20 AM12:10 寫道:

@rh-tchuang <https://github.com/rh-tchuang> - Sounds good to me; we'll do that next time. Could you send us the changes? We won't be able to merge this PR until Yadan's comments are resolved. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7224 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIFF355F5SZKIKAEA2NFJDSSZDHBANCNFSM4TXL6C4Q>.

-- Terry Chuang Sr. Localization Program Manager(Technical) RHCSA|RHCE|MCTS|CCNA Red Hat APAC Level 1, 193 North Quay Brisbane, QLD 4000 Australia

[rh-tchuang]

Hey Sam,
Understood about the PR approval, however there are specific strings that we need to address within frontend/packages/console-app/locales/ja/tour.json but it wasn't in the second batch for us to fix it as it's not treated as delta. Is there a way for us to fix it? Or perhaps during next round?

Cheers,
Terry

[rebeccaalpert]

For anyone following along at home, the required file been sent over and process adjusted off of GitHub.

@yapei - I uploaded the latest set of files in the newest commit. I went through and resolved the comments where it looked like the translation team had made updates. We're waiting on an additional Japanese file. I'll add that once we have it. Let me know if you have additional feedback in the meantime.

[spadgett]

Hey Sam,
Understood about the PR approval, however there are specific strings that we need to address within frontend/packages/console-app/locales/ja/tour.json but it wasn't in the second batch for us to fix it as it's not treated as delta. Is there a way for us to fix it? Or perhaps during next round?

Cheers,
Terry

Hey, @rh-tchuang. Is this because we sent only the delta last time? We're at the end of the sprint, so we can go ahead and send a full drop and update it in this PR. We'll send all strings going forward instead of only the delta. Thanks!

[rebeccaalpert]

Hey @rh-tchuang - I uploaded the revised files. Thanks for those. I went through @yapei's feedback and resolved the comments that were addressed. There are some things that weren't addressed. Would you guys be able to comment on the ones that weren't updated so we can get this further through QE?

It's ok if there were decisions not to translate certain things, but it would be great to have that documented in the comments on GitHub for Ya Dan.

[rh-tchuang]

Hey, @rh-tchuang. Is this because we sent only the delta last time? We're at the end of the sprint, so we can go ahead and send a full drop and update it in this PR. We'll send all strings going forward instead of only the delta. Thanks!

Hey Sam,
Yeah I think last time there were things that we couldn't address or made consistent because some of those files were treated as completed so not dropped into the second batch for sprint 192, hence our translator reported not able to address the comment made. It's just easier to make global changes when a comment is made against the same string several times. But I'm open to suggestions and if it's going to be problematic for QE, I'm happy to continue receiving deltas - but the same issue may happen again where we found a string that requires to be updated, we updated them in the current drop but not able to change the rest in other files within previous drop.

[rh-tchuang]

Hey @rh-tchuang - I uploaded the revised files. Thanks for those. I went through @yapei's feedback and resolved the comments that were addressed. There are some things that weren't addressed. Would you guys be able to comment on the ones that weren't updated so we can get this further through QE?

It's ok if there were decisions not to translate certain things, but it would be great to have that documented in the comments on GitHub for Ya Dan.

Hey Rebecca, yeah I've commented on all of them and tagged translator to clarify whether a particular string needs to be localized or not. I will resend you all the files that we have addressed but didn't seem to be picked up. As for some of the files not included within the current drop, we will need that to be sent to us again, and may be we can get a full batch next round so that all identical strings in question can be updated in one go.

[yapei]

@yanpzhan Could you review the comments?

[rebeccaalpert]

Sorry @yapei! I meant to tag @yanpzhan instead! Won't happen again.

[rebeccaalpert]

Hey Rebecca, yeah I've commented on all of them and tagged translator to clarify whether a particular string needs to be localized or not. I will resend you all the files that we have addressed but didn't seem to be picked up. As for some of the files not included within the current drop, we will need that to be sent to us again, and may be we can get a full batch next round so that all identical strings in question can be updated in one go.

Hey @rh-tchuang - Thanks so much! We'll send full file sets rather than deltas going forward. I'll send a batch over today that will include Sprint 193.

[yanpzhan]

@rebeccaalpert @rh-tchuang I reviewed all comments, and those updated items are good to me now, no new issue is found.
Should I add qe-approve label now or wait another review after those addressed in the translation files but not picked in for now in @rh-tfu 's comments to come in？

[rebeccaalpert]

@yanpzhan - I just added the latest set of files Terry sent over in response to your comments in the newest commit. Could you please review those and then if everything looks ok, add the qe-approve label? Thanks!

[yanpzhan]

/label qe-approved
Thanks all!

[spadgett]

/hold cancel

[spadgett]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[rh-tchuang]

@rebeccaalpert @rh-tchuang I reviewed all comments, and those updated items are good to me now, no new issue is found.
Should I add qe-approve label now or wait another review after those addressed in the translation files but not picked in for now in @rh-tfu 's comments to come in？

Thanks guys!
We're currently working on the sprint 193 batch, translation is completed for both zh/ja strings and waiting on some context clarifications; once those are addressed I'll be sending back the localized files.
Cheers