Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dev-console pipeline code into pipelines-plugin mono repo #7190

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Refactor dev-console pipeline code into pipelines-plugin mono repo #7190

merged 1 commit into from
Nov 13, 2020

Conversation

jeff-phillips-18
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-4538

Solution Description:
Created a new pipelines-plugin package, moved code from dev-console package there.

Non-functional change.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind cleanup

@openshift-ci-robot openshift-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. component/core Related to console core functionality labels Nov 11, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Nov 11, 2020
@jeff-phillips-18 jeff-phillips-18 force-pushed the pipelines-package branch 2 times, most recently from d1191a8 to 46c51bf Compare November 12, 2020 11:41
@jeff-phillips-18
Copy link
Member Author

/retest

andrewballantyne
andrewballantyne suggested changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an OWNERS file for the Pipeline plugin.

Something like:

reviewers:
  - andrewballantyne
  - abhinandan13jan
  - debsmita1
  - divyanshiGupta
  - christianvogt
  - invincibleJai
  - jerolimov
  - karthikjeeyar
  - nemesis09
  - rohitkrai03
  - rottencandy
  - sahil143
  - vikram-raj
approvers:
  - andrewballantyne
  - christianvogt
  - invincibleJai
  - rohitkrai03
labels:
  - component/pipeline

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 12, 2020
@jeff-phillips-18 jeff-phillips-18 force-pushed the pipelines-package branch 2 times, most recently from d7a8c2b to 9f81b1e Compare November 12, 2020 18:04
@jeff-phillips-18
Copy link
Member Author

/verify-owners

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 12, 2020
@andrewballantyne
Copy link
Contributor

/retest

@andrewballantyne
Copy link
Contributor

Ah, file reference issues in the errors.

andrewballantyne
andrewballantyne approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@andrewballantyne
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@andrewballantyne
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit c3f2ef4 into openshift:master Nov 13, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the pipelines-package branch December 2, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@andrewballantyne andrewballantyne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.
6 participants
@jeff-phillips-18 @andrewballantyne @christianvogt @openshift-ci-robot @spadgett @openshift-merge-robot