Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1897423: Update dc strategy type and rolling params #7200

Merged
merged 1 commit into from Nov 13, 2020

Conversation

yapei
Copy link
Contributor

@yapei yapei commented Nov 13, 2020

Deployment Config Details page is not showing Max unavailable and Max surge
Fixed it to use correct strategy type and parse from correct path
@jhadvig Could you help review?

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

@yapei: This pull request references Bugzilla bug 1897423, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1897423: Update dc strategy type and rolling params

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/core Related to console core functionality labels Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

@yapei: This pull request references Bugzilla bug 1897423, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yapei
Copy link
Contributor Author

yapei commented Nov 13, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@yapei: This pull request references Bugzilla bug 1897423, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 13, 2020
@yapei
Copy link
Contributor Author

yapei commented Nov 13, 2020

/test e2e-gcp-console

@openshift-ci-robot
Copy link
Contributor

@yapei: This pull request references Bugzilla bug 1897423, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1897423: Update dc strategy type and rolling params

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

/cherry-pick release-4.6

@openshift-cherrypick-robot

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4932f0b into openshift:master Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

@yapei: All pull requests linked via external trackers have merged:

Bugzilla bug 1897423 has been moved to the MODIFIED state.

In response to this:

Bug 1897423: Update dc strategy type and rolling params

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@spadgett: #7200 failed to apply on top of branch "release-4.6":

Applying: Bug 1897423: Update dc strategy type and rolling params
Using index info to reconstruct a base tree...
M	frontend/public/components/deployment-config.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/deployment-config.tsx
CONFLICT (content): Merge conflict in frontend/public/components/deployment-config.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1897423: Update dc strategy type and rolling params
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
@yapei
Copy link
Contributor Author

yapei commented Nov 17, 2020

/cherry-pick release-4.6

@openshift-cherrypick-robot

@yapei: #7200 failed to apply on top of branch "release-4.6":

Applying: Bug 1897423: Update dc strategy type and rolling params
Using index info to reconstruct a base tree...
M	frontend/public/components/deployment-config.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/deployment-config.tsx
CONFLICT (content): Merge conflict in frontend/public/components/deployment-config.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1897423: Update dc strategy type and rolling params
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants