Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1897423: Update dc strategy type and rolling params #7200

Merged
merged 1 commit into from Nov 13, 2020
Merged

Bug 1897423: Update dc strategy type and rolling params #7200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/public/components/deployment-config.tsx
View file
Open in desktop
Expand Up @@ -115,7 +115,7 @@ export const DeploymentConfigDetailsList = ({ dc }) => {
<DetailsItem label={t('workload~Latest version')} obj={dc} path="status.latestVersion" />
<DetailsItem label={t('workload~Message')} obj={dc} path="status.details.message" hideEmpty />
<DetailsItem label={t('workload~Update strategy')} obj={dc} path="spec.strategy.type" />
{dc.spec.strategy.type === 'RollingUpdate' && (
{dc.spec.strategy.type === 'Rolling' && (
<>
<DetailsItem
label={t('workload~Timeout')}
Expand Down Expand Up @@ -147,7 +147,7 @@ export const DeploymentConfigDetailsList = ({ dc }) => {
path="spec.strategy.rollingParams.maxUnavailable"
>
{t('workload~{{maxUnavailable}} of {{count}} pod', {
maxUnavailable: dc.spec.strategy.rollingUpdate.maxUnavailable ?? 1,
maxUnavailable: dc.spec.strategy.rollingParams.maxUnavailable ?? 1,
count: dc.spec.replicas,
})}
</DetailsItem>
Expand All @@ -157,7 +157,7 @@ export const DeploymentConfigDetailsList = ({ dc }) => {
path="spec.strategy.rollingParams.maxSurge"
>
{t('workload~{{maxSurge}} greater than {{count}} pod', {
maxSurge: dc.spec.strategy.rollingUpdate.maxSurge ?? 1,
maxSurge: dc.spec.strategy.rollingParams.maxSurge ?? 1,
count: dc.spec.replicas,
})}
</DetailsItem>
Expand Down