Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide edit icon for nodes without vcs URI #7216

Merged
merged 1 commit into from Nov 16, 2020
Merged

Hide edit icon for nodes without vcs URI #7216

merged 1 commit into from Nov 16, 2020

Conversation

rottencandy
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-5139

Analysis / Root cause:
Topology page crashes if application created using Git do not have vcsURI provided.

Solution Description:
Do not show edit icon if vcsURI is not provided.

Test setup:
Create an application using git flow and remove the git URL from it's annotations.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Nov 16, 2020
jerolimov
jerolimov approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally, works fine, thanks for the quick fix 👍

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@rottencandy
Copy link
Contributor Author

/cc @rohitkrai03

rohitkrai03
rohitkrai03 approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit dae0335 into openshift:master Nov 16, 2020
This was referenced Nov 16, 2020
Merged
Merged
@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
@rottencandy rottencandy deleted the giturl-fix branch December 7, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rottencandy @openshift-ci-robot @jerolimov @rohitkrai03 @spadgett @openshift-merge-robot