[release-4.5] Bug 1898102: Ensure correct git URL for topology edit icon #7219

rottencandy · 2020-11-16T11:51:17Z

Manual cherry-pick of #7158 and #7216

handle edit icon for nodes without vcs URI

openshift-ci-robot · 2020-11-16T11:51:22Z

@rottencandy: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1896296 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1896296 to target a release in 4.6.0, 4.6.z, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-11-24T14:29:00Z

@rottencandy Bugzillas need to be a linear line of release dependencies: 4.7 => 4.6.z => 4.5.z

Please fix up your 4.5.z ticket to look at the 4.6.z ticket.

rottencandy · 2020-11-24T15:24:37Z

/bugzilla refresh

openshift-ci-robot · 2020-11-24T15:24:41Z

@rottencandy: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-11-24T15:25:59Z

/lgtm

rottencandy · 2020-11-24T15:27:58Z

/assign @christianvogt

christianvogt · 2020-11-24T21:31:20Z

/approve

openshift-ci-robot · 2020-11-24T21:31:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-24T22:14:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-24T22:53:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-25T01:01:06Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-25T01:01:10Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-26T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-26T01:01:18Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-27T01:01:06Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-27T01:01:10Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-28T01:01:01Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-28T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-29T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-30T01:01:00Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-01T01:01:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-01T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-02T01:00:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-02T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-03T01:00:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-03T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-04T01:01:22Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-04T01:01:25Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-12-04T15:51:42Z

/bugzilla refresh

openshift-ci-robot · 2020-12-04T15:51:46Z

@andrewballantyne: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-05T01:02:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-05T01:02:43Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-06T01:01:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-06T01:01:41Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-07T01:01:03Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-07T01:01:07Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-08T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-08T01:01:03Z

@openshift-bot: This pull request references Bugzilla bug 1898102, which is invalid:

expected dependent Bugzilla bug 1898096 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2020-12-08T06:44:02Z

/bugzilla refresh

openshift-ci-robot · 2020-12-08T06:44:09Z

@rottencandy: This pull request references Bugzilla bug 1898102, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1898096 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1898096 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eparis · 2020-12-10T17:14:40Z

/bugzilla refresh

openshift-ci-robot · 2020-12-10T17:14:44Z

@eparis: This pull request references Bugzilla bug 1898102, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1898096 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1898096 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-10T18:49:34Z

@rottencandy: All pull requests linked via external trackers have merged:

openshift/console#7219

Bugzilla bug 1898102 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ensure correct git url for topology edit icon

9564f59

handle edit icon for nodes without vcs URI

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 16, 2020

openshift-ci-robot requested review from dtaylor113 and jeff-phillips-18 November 16, 2020 11:51

openshift-ci-robot added the component/dev-console Related to dev-console label Nov 16, 2020

andrewballantyne approved these changes Nov 24, 2020

View reviewed changes

openshift-ci-robot assigned andrewballantyne Nov 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020

openshift-ci-robot assigned christianvogt Nov 24, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 8, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 8, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 10, 2020

openshift-merge-robot merged commit 5ed5ef4 into openshift:release-4.5 Dec 10, 2020

spadgett added this to the v4.5.z milestone Jan 7, 2021

rottencandy deleted the giturl-4.5 branch February 8, 2021 08:09

[release-4.5] Bug 1898102: Ensure correct git URL for topology edit icon #7219

[release-4.5] Bug 1898102: Ensure correct git URL for topology edit icon #7219

Conversation

rottencandy commented Nov 16, 2020

openshift-ci-robot commented Nov 16, 2020

andrewballantyne commented Nov 24, 2020

rottencandy commented Nov 24, 2020

openshift-ci-robot commented Nov 24, 2020

andrewballantyne commented Nov 24, 2020

rottencandy commented Nov 24, 2020

christianvogt commented Nov 24, 2020

openshift-ci-robot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 25, 2020

openshift-ci-robot commented Nov 25, 2020

openshift-bot commented Nov 26, 2020

openshift-ci-robot commented Nov 26, 2020

openshift-bot commented Nov 27, 2020

openshift-ci-robot commented Nov 27, 2020

openshift-bot commented Nov 28, 2020

openshift-ci-robot commented Nov 28, 2020

openshift-bot commented Nov 29, 2020

openshift-ci-robot commented Nov 30, 2020

openshift-bot commented Dec 1, 2020

openshift-ci-robot commented Dec 1, 2020

openshift-bot commented Dec 2, 2020

openshift-ci-robot commented Dec 2, 2020

openshift-bot commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020

openshift-bot commented Dec 4, 2020

openshift-ci-robot commented Dec 4, 2020

andrewballantyne commented Dec 4, 2020

openshift-ci-robot commented Dec 4, 2020

openshift-bot commented Dec 5, 2020

openshift-ci-robot commented Dec 5, 2020

openshift-bot commented Dec 6, 2020

openshift-ci-robot commented Dec 6, 2020

openshift-bot commented Dec 7, 2020

openshift-ci-robot commented Dec 7, 2020

openshift-bot commented Dec 8, 2020

openshift-ci-robot commented Dec 8, 2020

rottencandy commented Dec 8, 2020

openshift-ci-robot commented Dec 8, 2020

eparis commented Dec 10, 2020

openshift-ci-robot commented Dec 10, 2020

openshift-ci-robot commented Dec 10, 2020