Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More i18n for vm details page #7250

Merged
merged 1 commit into from Nov 19, 2020
Merged

More i18n for vm details page #7250

merged 1 commit into from Nov 19, 2020

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Nov 18, 2020

More i18n for virtualization -> virtual machines -> details page

screenshot-localhost_9000-2020 11 18-10_46_00

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin labels Nov 18, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 18, 2020

@pcbailey @glekner @metalice please review

@yaacov yaacov changed the title More i18n for vm details page [WIP]More i18n for vm details page Nov 18, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 18, 2020

translation file is created in public directory instead of in our local plugin, set to WIP until this is cleared out.

@yaacov yaacov force-pushed the kubevirt-i18n-details-page-ii branch 2 times, most recently from 604357a to 47cbbbe Compare November 18, 2020 09:42
@yaacov
Copy link
Member Author

yaacov commented Nov 18, 2020

/test e2e-gcp-console

pcbailey
pcbailey reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@pcbailey pcbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are strings in a few files that I think should to be translated, but were in sections that didn't allow me to make per-line comments. I've included the files and lines below.

kubevirt-plugin/src/components/modals/scheduling-modals/dedicated-resources-modal/dedicated-resources-modal.tsx
Line numbers: 75, 85, 98, 102, 105

frontend/packages/kubevirt-plugin/src/components/modals/scheduling-modals/tolerations-modal/tolerations-modal.tsx
Line numbers: 111, 115, 118, 128, 129

frontend/packages/kubevirt-plugin/src/components/vm-templates/vm-template-resource.tsx
Line numbers: 48, 52, 61, 66, 74, 94,

@yaacov
Copy link
Member Author

yaacov commented Nov 18, 2020

@pcbailey +1 thanks

@yaacov yaacov force-pushed the kubevirt-i18n-details-page-ii branch 2 times, most recently from e24dffd to de329c1 Compare November 18, 2020 15:28
@yaacov yaacov changed the title [WIP]More i18n for vm details page More i18n for vm details page Nov 18, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 18, 2020

removed WIP, the json file is back in the plugin dir,
I translated by mistake a string in common namesapce that moved the .json file to the common directory.

@yaacov yaacov force-pushed the kubevirt-i18n-details-page-ii branch 2 times, most recently from 4c69456 to 6463aa6 Compare November 18, 2020 16:19
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@yaacov yaacov force-pushed the kubevirt-i18n-details-page-ii branch from 6463aa6 to 18efa51 Compare November 18, 2020 16:21
@yaacov
Copy link
Member Author

yaacov commented Nov 18, 2020

@pcbailey added the missing translations +1, please re-review

@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov yaacov mentioned this pull request Nov 19, 2020
Merged
@yaacov
Copy link
Member Author

yaacov commented Nov 19, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 33f3773 into openshift:master Nov 19, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey pcbailey left review comments

@irosenzw irosenzw Awaiting requested review from irosenzw

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yaacov @pcbailey @openshift-ci-robot @spadgett @openshift-merge-robot