Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubevit i18n overview page i #7271

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Nov 19, 2020

More i18n for the VM Overview page:

screenshot-localhost_9000-2020 11 19-16_40_39

Based on: #7250

@yaacov yaacov changed the title Kubevit i18n overview page i [WIP]Kubevit i18n overview page i Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/kubevirt Related to kubevirt-plugin labels Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 19, 2020

WIP because it's based on #7250

@yaacov
Copy link
Member Author

yaacov commented Nov 19, 2020

cc:// @pcbailey ( WIP because based on #7250 )

@yaacov yaacov changed the title [WIP]Kubevit i18n overview page i Kubevit i18n overview page i Nov 19, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2020
@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch from e7034e5 to f107a30 Compare November 19, 2020 16:39
@yaacov
Copy link
Member Author

yaacov commented Nov 19, 2020

@pcbailey please review

@yaacov
Copy link
Member Author

yaacov commented Nov 19, 2020

/retest

@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch from f107a30 to 38c8c09 Compare November 20, 2020 04:31
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2020
@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch from 38c8c09 to 2ffbdf9 Compare November 20, 2020 04:51
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2020
@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch from 2ffbdf9 to 7bc076c Compare November 20, 2020 05:12
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 20, 2020

/retest

2 similar comments
@yaacov
Copy link
Member Author

yaacov commented Nov 22, 2020

/retest

@yaacov
Copy link
Member Author

yaacov commented Nov 22, 2020

/retest

@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch from 7bc076c to a5ae6a3 Compare November 22, 2020 09:34
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2020
@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch from a5ae6a3 to 299927e Compare November 22, 2020 10:16
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2020
@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch 2 times, most recently from a5d065a to fa35df2 Compare November 22, 2020 10:55
@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch 2 times, most recently from 2ea0273 to 0755af8 Compare November 22, 2020 11:21
Copy link
Contributor

@irosenzw irosenzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@irosenzw
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 22, 2020

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2020
@yaacov yaacov force-pushed the kubevit-i18n-overview-page-i branch from 0755af8 to 95abe3c Compare November 22, 2020 11:47
@irosenzw
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member Author

yaacov commented Nov 22, 2020

/retest

1 similar comment
@yaacov
Copy link
Member Author

yaacov commented Nov 22, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1f8dc9a into openshift:master Nov 22, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants