-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1879056: Added eviction strategy support #7276
Bug 1879056: Added eviction strategy support #7276
Conversation
/retitle Bug 1879056: Added eviction strategy support #7276 |
@metalice: This pull request references Bugzilla bug 1879056, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle Bug 1879056: Added eviction strategy support |
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vmi-wrapper.ts
Outdated
Show resolved
Hide resolved
cbb1ebb
to
be020bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job @metalice
left some comments
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx
Outdated
Show resolved
Hide resolved
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx
Outdated
Show resolved
Hide resolved
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx
Outdated
Show resolved
Hide resolved
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx
Outdated
Show resolved
Hide resolved
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx
Outdated
Show resolved
Hide resolved
be020bb
to
0289ae6
Compare
/retest |
@glekner Changed according your comments 👍 |
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vmi-wrapper.ts
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts
Outdated
Show resolved
Hide resolved
0289ae6
to
8e15dd2
Compare
mazal tov on 1st PR! 🥇 /lgtm |
/retest |
8e15dd2
to
4c3ab99
Compare
4c3ab99
to
6a6ff36
Compare
6a6ff36
to
82a5cfa
Compare
/retest |
…checkbox to control it. Also, changed some styling and translation in dedicated-services-modal Signed-off-by: metalice <mschatzm@redhat.com>
82a5cfa
to
1fbc970
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glekner, metalice, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@metalice: All pull requests linked via external trackers have merged: Bugzilla bug 1879056 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
Fix Bugzilla 189056
Analysis / Root cause:
UI didnt had a way to support eviciton strategy
Solution Description:
Add eviction strategy to machine details page, with a modal and a checkbox to tick LiveMigration (the only option) on/off.
Screen shots / Gifs for design review:
Signed-off-by: metalice mschatzm@redhat.com