Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1879056: Added eviction strategy support #7276

Merged
merged 1 commit into from Nov 23, 2020
Merged

Bug 1879056: Added eviction strategy support #7276

merged 1 commit into from Nov 23, 2020

Conversation

metalice
Copy link
Contributor

Fixes:

Fix Bugzilla 189056

Analysis / Root cause:

UI didnt had a way to support eviciton strategy

Solution Description:

Add eviction strategy to machine details page, with a modal and a checkbox to tick LiveMigration (the only option) on/off.

Screen shots / Gifs for design review:


eviction-strategy-gif

Signed-off-by: metalice mschatzm@redhat.com

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/kubevirt Related to kubevirt-plugin labels Nov 19, 2020
@yaacov
Copy link
Member

yaacov commented Nov 20, 2020

/retitle Bug 1879056: Added eviction strategy support #7276

@openshift-ci-robot openshift-ci-robot changed the title Bugzilla 1879056 - Added eviction strategy support Bug 1879056: Added eviction strategy support #7276 Nov 20, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 20, 2020
@openshift-ci-robot
Copy link
Contributor

@metalice: This pull request references Bugzilla bug 1879056, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1879056: Added eviction strategy support #7276

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Nov 20, 2020

/retitle Bug 1879056: Added eviction strategy support

@openshift-ci-robot openshift-ci-robot changed the title Bug 1879056: Added eviction strategy support #7276 Bug 1879056: Added eviction strategy support Nov 20, 2020
@metalice metalice force-pushed the bz-1879056-kubevirt-added-eviction-strategy branch from cbb1ebb to be020bb Compare November 22, 2020 09:31
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2020
@metalice
Copy link
Contributor Author

@glekner @irosenzw please review :)

glekner
glekner suggested changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@glekner glekner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @metalice
left some comments

.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx Outdated Show resolved Hide resolved
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx Outdated Show resolved Hide resolved
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx Outdated Show resolved Hide resolved
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx Outdated Show resolved Hide resolved
.../src/components/modals/scheduling-modals/eviction-strategy-modal/eviction-strategy-modal.tsx Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx Show resolved Hide resolved
@metalice metalice force-pushed the bz-1879056-kubevirt-added-eviction-strategy branch from be020bb to 0289ae6 Compare November 22, 2020 11:58
@metalice
Copy link
Contributor Author

/retest

@metalice
Copy link
Contributor Author

@glekner Changed according your comments 👍

@metalice metalice force-pushed the bz-1879056-kubevirt-added-eviction-strategy branch from 0289ae6 to 8e15dd2 Compare November 22, 2020 13:55
@metalice metalice requested a review from yaacov November 22, 2020 13:57
@glekner
Copy link
Contributor

glekner commented Nov 22, 2020

mazal tov on 1st PR! 🥇

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2020
@yaacov
Copy link
Member

yaacov commented Nov 22, 2020

/retest

@metalice metalice force-pushed the bz-1879056-kubevirt-added-eviction-strategy branch from 8e15dd2 to 4c3ab99 Compare November 22, 2020 15:22
@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2020
@metalice metalice force-pushed the bz-1879056-kubevirt-added-eviction-strategy branch from 4c3ab99 to 6a6ff36 Compare November 22, 2020 15:54
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2020
@metalice metalice force-pushed the bz-1879056-kubevirt-added-eviction-strategy branch from 6a6ff36 to 82a5cfa Compare November 22, 2020 16:02
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2020
@yaacov
Copy link
Member

yaacov commented Nov 22, 2020

/retest

@metalice
Added eviction strategy information on details page and a model with …
1fbc970 
…checkbox to control it.

Also, changed some styling and translation in dedicated-services-modal

Signed-off-by: metalice <mschatzm@redhat.com>
@metalice metalice force-pushed the bz-1879056-kubevirt-added-eviction-strategy branch from 82a5cfa to 1fbc970 Compare November 22, 2020 20:13
@yaacov
Copy link
Member

yaacov commented Nov 23, 2020

/retest

@yaacov
Copy link
Member

yaacov commented Nov 23, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, metalice, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dfba93b into openshift:master Nov 23, 2020
@openshift-ci-robot
Copy link
Contributor

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 1879056 has been moved to the MODIFIED state.

In response to this:

Bug 1879056: Added eviction strategy support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glekner glekner glekner requested changes

@irosenzw irosenzw Awaiting requested review from irosenzw

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@yaacov yaacov

@glekner glekner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@metalice @yaacov @openshift-ci-robot @glekner @spadgett @openshift-merge-robot