Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devfile Add Flow #7299

Merged
merged 3 commits into from Dec 4, 2020
Merged

Devfile Add Flow #7299

merged 3 commits into from Dec 4, 2020

Conversation

andrewballantyne
Copy link
Contributor

@andrewballantyne andrewballantyne commented Nov 23, 2020 •
edited

Original effort was done by @reginapizza and @jaideepr97 on #6321

This PR is split up into 3 commits

  • First Commit is the Frontend Work
  • Second Commit is the Backend Work
  • Third Commit (and the majority of lines changed) is the Golang Dependencies portion -- shouldn't need to look at this one

Fixes:
https://issues.redhat.com/browse/ODC-1052

Solution Description:
Support a Devfile Import flow in Dev Preview.

Backend library work is being done in devfile/library#44

Screen shots / Gifs for design review:
cc @openshift/team-devconsole-ux

Add Tile
Screen Shot 2020-11-29 at 11 14 21 PM
Initial Form Load
Screen Shot 2020-11-29 at 11 14 33 PM
Non-Devfile Repo
Screen Shot 2020-11-29 at 11 14 45 PM
Devfile Repo (successfully communicated with the backend for resources)
Screen Shot 2020-11-29 at 11 15 25 PM
Devfile Sample
Screen Shot 2020-12-02 at 11 12 31 AM
Sucessfully deployed "sample":
Screen Shot 2020-12-02 at 11 07 14 AM

Unit test coverage report:
TBD

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/backend Related to backend labels Nov 23, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service labels Nov 23, 2020
@andrewballantyne andrewballantyne mentioned this pull request Nov 23, 2020
Closed
@andrewballantyne
Copy link
Contributor Author

cc @maysunfaisal @elsony @reginapizza

@maysunfaisal maysunfaisal mentioned this pull request Nov 26, 2020
Closed
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2020
@andrewballantyne andrewballantyne force-pushed the devfile-rework branch 5 times, most recently from a2492e0 to f06c376 Compare November 30, 2020 20:03
@andrewballantyne
Copy link
Contributor Author

Updated the co-authors on each commit to include those who helped out.

@andrewballantyne andrewballantyne force-pushed the devfile-rework branch 3 times, most recently from ed2f360 to 6a9ef5c Compare December 1, 2020 03:29
@andrewballantyne
Copy link
Contributor Author

@maysunfaisal I had to reset the go dependencies because it wouldn't build. Let me know if this is a good state for the dependencies.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2020
andrewballantyne
andrewballantyne commented Dec 1, 2020
View reviewed changes
modules.txt Outdated Show resolved Hide resolved
@andrewballantyne andrewballantyne force-pushed the devfile-rework branch 3 times, most recently from e36ee61 to 073bbe5 Compare December 3, 2020 15:20
vikram-raj
vikram-raj reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it, and Devfile Add Flow works as expected.
Thanks @andrewballantyne

jhadvig
jhadvig requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Otherwise the backend part of the PR looks good 👍

cmd/bridge/main.go Outdated Show resolved Hide resolved
@spadgett
Copy link
Member

spadgett commented Dec 3, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
andrewballantyne and others added 3 commits December 3, 2020 17:25
@andrewballantyne @reginapizza @jaideepr97
Devfile - Frontend
05cab2e 
Co-Authored-By: Regina Scott <reginaelyse@gmail.com>
Co-Authored-By: Jaideep Raghunath Rao <jaideep.r97@gmail.com>
@andrewballantyne @maysunfaisal
@reginapizza @jaideepr97
Devfile - Backend
bdf02e6 
Co-Authored-By: Maysun J Faisal <maysunaneek@gmail.com>
Co-Authored-By: Regina Scott <reginaelyse@gmail.com>
Co-Authored-By: Jaideep Raghunath Rao <jaideep.r97@gmail.com>
@andrewballantyne @maysunfaisal
@reginapizza @jaideepr97
Devfile - Backend (dependencies)
508728f 
Co-Authored-By: Maysun J Faisal <maysunaneek@gmail.com>
Co-Authored-By: Regina Scott <reginaelyse@gmail.com>
Co-Authored-By: Jaideep Raghunath Rao <jaideep.r97@gmail.com>
@andrewballantyne
Copy link
Contributor Author

/test

@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test analyze
  • /test backend
  • /test e2e-gcp-console
  • /test frontend
  • /test images
  • /test kubevirt-plugin

Use /test all to run the following jobs:

  • pull-ci-openshift-console-master-analyze
  • pull-ci-openshift-console-master-backend
  • pull-ci-openshift-console-master-e2e-gcp-console
  • pull-ci-openshift-console-master-frontend
  • pull-ci-openshift-console-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Contributor Author

/retest

1 similar comment
@andrewballantyne
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit e7ca931 into openshift:master Dec 4, 2020
@andrewballantyne andrewballantyne deleted the devfile-rework branch December 4, 2020 14:22
@maysunfaisal maysunfaisal mentioned this pull request Dec 4, 2020
Merged
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@andrewballantyne andrewballantyne mentioned this pull request Dec 11, 2020
Merged
@andrewballantyne andrewballantyne mentioned this pull request May 17, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@jaideepr97 jaideepr97 jaideepr97 left review comments

@reginapizza reginapizza reginapizza left review comments

@jhadvig jhadvig jhadvig requested changes

@kyoto kyoto Awaiting requested review from kyoto

@rhamilto rhamilto Awaiting requested review from rhamilto

@spadgett spadgett Awaiting requested review from spadgett

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@sahil143 sahil143 Awaiting requested review from sahil143

@maysunfaisal maysunfaisal Awaiting requested review from maysunfaisal

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet