Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1906745: Upgrade Helm to 3.4.2 #7517

Merged
merged 1 commit into from Dec 12, 2020
Merged

Bug 1906745: Upgrade Helm to 3.4.2 #7517

merged 1 commit into from Dec 12, 2020

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Dec 10, 2020 •
edited

This is for issue https://issues.redhat.com/browse/HELM-47

  • upgrades Helm go module to 3.4.2
  • go mod tidy & go mod vendor
  • updates all the test index files for Helm 3.4.2

P.S.
If you're coming back to look at this PR for googleapis vendor changes, the module path changed from vendor/github.com/googleapis/gnostic/OpenAPIv2 to vendor/github.com/googleapis/gnostic/openapiv2

You may set the git config to take this into account

 git config core.ignorecase false

@openshift-ci-robot openshift-ci-robot added the component/backend Related to backend label Dec 10, 2020
@pedjak
Copy link
Contributor

pedjak commented Dec 11, 2020

/lgtm
/approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@pedjak
Copy link
Contributor

pedjak commented Dec 11, 2020

/retitle Bug 1906745: Upgrade Helm to 3.4.1

@openshift-ci-robot openshift-ci-robot changed the title Upgrade Helm to 3.4.1 & update Helm test index files Bug 1906745: Upgrade Helm to 3.4.1 Dec 11, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@maysunfaisal: This pull request references Bugzilla bug 1906745, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906745: Upgrade Helm to 3.4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 11, 2020
@pedjak
Copy link
Contributor

pedjak commented Dec 11, 2020

/bugzilla-refresh

@pedjak
Copy link
Contributor

pedjak commented Dec 11, 2020

@maysunfaisal the latest version is 3.4.2, so since we perform update now, let's upgrade to that instead?

@maysunfaisal
Upgrade Helm and update helm index file tests
f52cad4 
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@pedjak
Copy link
Contributor

pedjak commented Dec 11, 2020

/retitle Bug 1906745: Upgrade Helm to 3.4.2

@pedjak
Copy link
Contributor

pedjak commented Dec 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot changed the title Bug 1906745: Upgrade Helm to 3.4.1 Bug 1906745: Upgrade Helm to 3.4.2 Dec 11, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@maysunfaisal: This pull request references Bugzilla bug 1906745, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1906745: Upgrade Helm to 3.4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 11, 2020
@maysunfaisal
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@maysunfaisal: This pull request references Bugzilla bug 1906745, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Dec 11, 2020
@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: This pull request references Bugzilla bug 1906745, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pedjak
Copy link
Contributor

pedjak commented Dec 11, 2020

/bugzilla-refresh

@andrewballantyne
Copy link
Contributor

/assign @spadgett @jhadvig

This is related to the work in #7424 and a continuation of the lib issue in #7299

spadgett
spadgett approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde, maysunfaisal, pedjak, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akashshinde
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 90601e0 into openshift:master Dec 12, 2020
@openshift-ci-robot
Copy link
Contributor

@maysunfaisal: All pull requests linked via external trackers have merged:

Bugzilla bug 1906745 has been moved to the MODIFIED state.

In response to this:

Bug 1906745: Upgrade Helm to 3.4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@akashshinde akashshinde akashshinde approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@pedjak pedjak

@spadgett spadgett

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/backend Related to backend lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@maysunfaisal @pedjak @openshift-ci-robot @andrewballantyne @akashshinde @spadgett @jhadvig @openshift-merge-robot