Localize VM NICs and disks modals #7307
Conversation
openshift-ci-robot
added
the
approved
|
/retest |
| @@ -354,12 +348,19 @@ export const DiskModal = withHandlePromise((props: DiskModalProps) => { | |||
| return ( | |||
| <div className="modal-content"> | |||
| <ModalTitle> | |||
| {isEditing ? EDIT : ADD} {type.toString()} | |||
| {isEditing ? t('kubevirt-plugin~Edit') : t('kubevirt-plugin~Add')}{' '} | |||
| {t('kubevirt-plugin~{{type}}', { type: type.toString() })} | |||
There was a problem hiding this comment.
Notes to next pass:
this will not get translated unless we have comments with // t('kubevirt-plugin~<all posible types... > ... do we need it translated ?
There was a problem hiding this comment.
You're right. I added these earlier on before I understood about the comments hack. I've been meaning to take them out and forgot. I'll remove them in the next pass.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| }) => { | ||
| const { t } = useTranslation(); | ||
|
|
||
| const titleText = title || t('kubevirt-plugin~Size'); |
This PR updates the modals for VM NICs and disks. It does not update the options in the drop down menus. That will be completed in a separate PR.
Disks modal:
Network interfaces modal:
