Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt wizard custom flavort memory lable #7348

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Nov 29, 2020

Fix custom flavour label in vm wizard.

Before fix:
screenshot-localhost_9000-2020 11 29-13_40_37

After fix:
screenshot-localhost_9000-2020 11 29-13_39_37

Ref:
#7307 (review)

@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 29, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 29, 2020

@glekner @irosenzw @metalice please review

@glekner
Copy link
Contributor

glekner commented Nov 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member Author

yaacov commented Nov 29, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7d45be6 into openshift:master Nov 29, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants