Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1901594: bump node-sass to 5.0.0 #7365

Merged
merged 3 commits into from Dec 2, 2020
Merged

Bug 1901594: bump node-sass to 5.0.0 #7365

merged 3 commits into from Dec 2, 2020

Conversation

spadgett
Copy link
Member

This addresses a build failure with Node.js 14. The older node-sass version required Python 2.

@spadgett
frontend: bump node-sass to 5.0.0
2f7e97a 
This addresses a build failure with Node.js 14. The older node-sass
version required Python 2.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@spadgett
Copy link
Member Author

cc @yselkowitz

I'm not sure offhand if this fixes the problem if python3 is not available. Do you know? We could still need #7364.

yselkowitz added a commit to yselkowitz/ocp-build-data that referenced this pull request Nov 30, 2020
@yselkowitz
update-console-sources: use python3 for newer node-sass
8a80bd2 
This corresponds to openshift/console#7365
@spadgett
Merge pull request #5 from multi-arch/upgrade-node-sass
1b8a801 
Use python3 in Dockerfile.product
@yselkowitz yselkowitz mentioned this pull request Nov 30, 2020
Merged
@openshift-ci-robot openshift-ci-robot assigned rhamilto and yaacov and unassigned yaacov Nov 30, 2020
@spadgett
Copy link
Member Author

/assign @yselkowitz

@yselkowitz yselkowitz mentioned this pull request Nov 30, 2020
Closed
@yselkowitz
Copy link
Contributor

yselkowitz commented Nov 30, 2020 •
edited

A local build of downstream with this applied worked for me, let's see how CI goes.

@yselkowitz
Copy link
Contributor

/retest

3 similar comments
@yselkowitz
Copy link
Contributor

/retest

@spadgett
Copy link
Member Author

spadgett commented Dec 1, 2020

/retest

@yselkowitz
Copy link
Contributor

/retest

@spadgett
Copy link
Member Author

spadgett commented Dec 1, 2020

/assign @rhamilto

@spadgett spadgett changed the title frontend: bump node-sass to 5.0.0 Bug 1901594: bump node-sass to 5.0.0 Dec 2, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1901594, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1901594: bump node-sass to 5.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 2, 2020
@spadgett
Copy link
Member Author

spadgett commented Dec 2, 2020

This will indirectly fix the test failures we're seeing in the openshift-ocp-installer-console-aws-4.7 job.

@spadgett spadgett mentioned this pull request Dec 2, 2020
Closed
@rhamilto
Copy link
Member

rhamilto commented Dec 2, 2020

/lgtm

@spadgett spadgett added kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/test-flake Categorizes issue or PR as related to test flakes. labels Dec 2, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 14e9469 into openshift:master Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged:

Bugzilla bug 1901594 has been moved to the MODIFIED state.

In response to this:

Bug 1901594: bump node-sass to 5.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the upgrade-node-sass branch December 8, 2020 20:22
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@jhadvig jhadvig mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoto kyoto Awaiting requested review from kyoto

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@rhamilto rhamilto

@yselkowitz yselkowitz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/test-flake Categorizes issue or PR as related to test flakes. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spadgett @yselkowitz @openshift-ci-robot @rhamilto @yaacov @openshift-merge-robot