Create stretch cluster with arbiter node. #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
afreen23
suggested changes
Dec 1, 2020
...c/components/ocs-install/attached-devices/create-sc/wizard-pages/create-local-volume-set.tsx
Outdated
Show resolved
Hide resolved
...c/components/ocs-install/attached-devices/create-sc/wizard-pages/create-local-volume-set.tsx
Outdated
Show resolved
Hide resolved
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
1ce3988
to
071fec5
Compare
|
/test e2e-gcp-console |
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
071fec5
to
c91c882
Compare
afreen23
suggested changes
Dec 2, 2020
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
c91c882
to
ae663b3
Compare
openshift-ci-robot
added
the
needs-rebase
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
ae663b3
to
82cb5f6
Compare
openshift-ci-robot
removed
the
needs-rebase
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
82cb5f6
to
5c7b07a
Compare
|
/retest |
afreen23
suggested changes
Dec 3, 2020
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
cloudbehl
force-pushed
the
arbiter-cluster
branch
2 times, most recently
from
36bf14c
to
ff10387
Compare
afreen23
suggested changes
Dec 4, 2020
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Show resolved
Hide resolved
|
/lgtm |
bipuladh
suggested changes
Dec 4, 2020
...c/components/ocs-install/attached-devices/create-sc/wizard-pages/create-local-volume-set.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/review-and-create-step.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
|
@cloudbehl can you also move ArbiterFormGroup to the |
bipuladh
reviewed
Dec 4, 2020
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
Outdated
Show resolved
Hide resolved
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
ff10387
to
4f1e773
Compare
bipuladh
suggested changes
Dec 4, 2020
...ackages/ceph-storage-plugin/src/components/ocs-install/install-wizard/capacity-and-nodes.tsx
Outdated
Show resolved
Hide resolved
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
4f1e773
to
4adc589
Compare
|
/lgtm |
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
4adc589
to
ff765aa
Compare
afreen23
suggested changes
Dec 4, 2020
...ackages/ceph-storage-plugin/src/components/ocs-install/install-wizard/capacity-and-nodes.tsx
Outdated
Show resolved
Hide resolved
...ackages/ceph-storage-plugin/src/components/ocs-install/install-wizard/capacity-and-nodes.tsx
Outdated
Show resolved
Hide resolved
...ackages/ceph-storage-plugin/src/components/ocs-install/install-wizard/capacity-and-nodes.tsx
Outdated
Show resolved
Hide resolved
...ackages/ceph-storage-plugin/src/components/ocs-install/install-wizard/capacity-and-nodes.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ceph-storage-plugin/src/components/ocs-install/ocs-request-data.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ceph-storage-plugin/src/components/ocs-install/ocs-request-data.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ceph-storage-plugin/src/components/ocs-install/ocs-request-data.ts
Outdated
Show resolved
Hide resolved
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
ff765aa
to
7aa1890
Compare
openshift-ci-robot
added
component/core
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
7aa1890
to
04404d4
Compare
openshift-ci-robot
added
the
approved
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
cloudbehl
force-pushed
the
arbiter-cluster
branch
from
04404d4
to
02355c3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a2batic, bipuladh, cloudbehl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankush Behl cloudbehl@gmail.com