Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1909678: Hide scale buttons of pod donut for Pod resources #7444

Merged
merged 1 commit into from Dec 8, 2020

Conversation

rottencandy
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-5145

Analysis / Root cause:
Scale up / down buttons are available for a single Pod resource and results in an error when pressed.

Solution Description:
The buttons are hidden if the resource is of type Pod.

Screen shots / Gifs for design review:
tmp

Test setup:

  • Create a single pod
  • Go to Details tab in side panel of the pod node

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Dec 7, 2020
@rottencandy
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 7, 2020
@christianvogt
Copy link
Contributor

Can you make the original hook more efficient if we know that scaling is not allowed, there's no need to check the access in the effect.

@rottencandy
Copy link
Contributor Author

Can you make the original hook more efficient if we know that scaling is not allowed, there's no need to check the access in the effect.

Updated.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 8, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3f80516 into openshift:master Dec 8, 2020
@rottencandy
Copy link
Contributor Author

/cherrypick release-4.6

@openshift-cherrypick-robot

@rottencandy: new pull request created: #7472

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@rottencandy rottencandy changed the title Hide scale buttons of pod donut for Pod resources Bug 1909678: Hide scale buttons of pod donut for Pod resources Dec 21, 2020
@openshift-ci-robot
Copy link
Contributor

@rottencandy: All pull requests linked via external trackers have merged:

Bugzilla bug 1909678 has been moved to the MODIFIED state.

In response to this:

Bug 1909678: Hide scale buttons of pod donut for Pod resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rottencandy
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@rottencandy: Bugzilla bug 1909678 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rottencandy rottencandy deleted the podscale branch February 8, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants