New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1909678: Hide scale buttons of pod donut for Pod resources #7444
Conversation
/kind bug |
Can you make the original hook more efficient if we know that scaling is not allowed, there's no need to check the access in the effect. |
Updated. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/cherrypick release-4.6 |
@rottencandy: new pull request created: #7472 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rottencandy: All pull requests linked via external trackers have merged: Bugzilla bug 1909678 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rottencandy: Bugzilla bug 1909678 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5145
Analysis / Root cause:
Scale up / down buttons are available for a single Pod resource and results in an error when pressed.
Solution Description:
The buttons are hidden if the resource is of type Pod.
Screen shots / Gifs for design review:
Test setup:
Browser conformance: