Bug 1905253: update events timeline empty state and end messages #7467

rhamilto · 2020-12-08T17:17:12Z

Before:

After:

openshift-ci-robot · 2020-12-08T17:17:17Z

@rhamilto: An error was encountered adding this pull request to the external tracker bugs for bug 1905253 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/console/pulls/7467 Error: 403 Forbidden at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x556e2a...', 'https://api.github.com/repos/openshift/console/pulls/7467', 'GET') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x556e2a...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x556e2ae876e0)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x556e2ae876e0)', 1) called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x556e28b71bc8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x556e288b4528)', 'HASH(0x556e28e11170)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x556e28e11170)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x556e2b105c58)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b76c00)') called at (eval 2953) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b62e90)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b62e90)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x556e296f8588)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x556e2a2ca8c0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x556e2a2ca8c0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x556e296f8588)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x556e296f8588)') called at (eval 2953) line 0 eval {...} called at (eval 2953) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x556e2a783320)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x556e2a783320)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x556e2a...', 'https://api.github.com/repos/openshift/console/pulls/7467', 'GET') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x556e2a...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x556e2ae876e0)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x556e2ae876e0)', 1) called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x556e28b71bc8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x556e288b4528)', 'HASH(0x556e28e11170)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x556e28e11170)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x556e2b105c58)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b76c00)') called at (eval 2953) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b62e90)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b62e90)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x556e296f8588)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x556e2a2ca8c0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x556e2a2ca8c0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x556e296f8588)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x556e296f8588)') called at (eval 2953) line 0 eval {...} called at (eval 2953) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1905253: update events timeline end message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2020-12-08T17:19:39Z

/bugzilla refresh

openshift-ci-robot · 2020-12-08T17:19:42Z

@rhamilto: An error was encountered adding this pull request to the external tracker bugs for bug 1905253 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/console/pulls/7467 Error: 403 Forbidden at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x556e28...', 'https://api.github.com/repos/openshift/console/pulls/7467', 'GET') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x556e28...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x556e28438120)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x556e28438120)', 1) called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x556e283db3f8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x556e286c4638)', 'HASH(0x556e28afceb8)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x556e28afceb8)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x556e2896f458)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e29469e30)') called at (eval 2153) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b54dc8)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b54dc8)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x556e28ad8670)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x556e2945a700)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x556e2945a700)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x556e28ad8670)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x556e28ad8670)') called at (eval 2153) line 0 eval {...} called at (eval 2153) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x556e283db3e0)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x556e283db3e0)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x556e28...', 'https://api.github.com/repos/openshift/console/pulls/7467', 'GET') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x556e28...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x556e28438120)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x556e28438120)', 1) called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x556e283db3f8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x556e286c4638)', 'HASH(0x556e28afceb8)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x556e28afceb8)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x556e2896f458)') called at /loader/0x556e1b5970d8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e29469e30)') called at (eval 2153) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b54dc8)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x556e28b54dc8)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x556e28ad8670)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x556e2945a700)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x556e2945a700)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x556e28ad8670)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x556e28ad8670)') called at (eval 2153) line 0 eval {...} called at (eval 2153) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andybraren

Thanks for the quick fix, lgtm!

rhamilto · 2020-12-08T17:48:59Z

/retest

rhamilto · 2020-12-08T18:26:47Z

/retest

rhamilto · 2020-12-08T19:36:19Z

/retest

spadgett · 2020-12-11T16:57:39Z

frontend/public/components/events.jsx

@@ -516,7 +516,7 @@ class EventStream extends React.Component {
              className="co-sysevent-stream__timeline__btn"
            />
            <div className="co-sysevent-stream__timeline__end-message">
-              There are no events before <Timestamp timestamp={this.state.oldestTimestamp} />
+              Events older than 2 hours are not stored.


The default TTL is one hour, but I believe it can be changed. We might not be able to hard-code the message.

I just noticed the empty state message is No events in the past hour. If the TTL can be changed, the empty state message also needs updating. Perhaps we just do:

Older events are not stored. and No events so as to keep the messages precise? @andybraren, your thoughts?

I like those tweaks @rhamilto, both of which are better than what they are today. I posted in #forum-monitoring to see if the 1 hour is configurable.

Oh, I just found this which suggests the default is 3 hours and isn't configurable (at least in a supported way)? 🤷‍♂️
https://access.redhat.com/solutions/5170631

@sttts Do you know what the default event TTL is and if it can be configured in OpenShift?

https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/bindata/v4.1.0/config/defaultconfig.yaml#L96

openshift-ci-robot · 2020-12-11T21:13:13Z

@rhamilto: This pull request references Bugzilla bug 1905253, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1905253: update events timeline end message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2020-12-22T16:18:38Z

/hold for resolution on wording

spadgett

/lgtm

spadgett · 2021-01-04T18:13:59Z

@andybraren @itsptk Does the wording look good?

andybraren

Older events are not stored and No events seem like the safest ways to phrase this, so lgtm!

openshift-ci-robot · 2021-01-04T18:56:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andybraren, rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spadgett · 2021-01-04T20:26:48Z

/hold cancel

spadgett · 2021-01-04T20:27:01Z

/retest

openshift-bot · 2021-01-04T21:08:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-04T21:47:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

rhamilto · 2021-01-04T22:12:03Z

/retest

openshift-bot · 2021-01-04T23:31:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-04T23:44:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T00:23:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T01:28:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T02:20:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T02:46:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T03:12:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T04:04:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T06:40:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-01-05T07:53:57Z

@rhamilto: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/kubevirt-plugin	`0b9acd3`	link	`/test kubevirt-plugin`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-01-05T08:24:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T08:37:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-01-05T12:18:36Z

@rhamilto: All pull requests linked via external trackers have merged:

openshift/console#7467

Bugzilla bug 1905253 has been moved to the MODIFIED state.

In response to this:

Bug 1905253: update events timeline empty state and end messages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto assigned andybraren and TheRealJon Dec 8, 2020

openshift-ci-robot added the component/core Related to console core functionality label Dec 8, 2020

openshift-ci-robot requested review from dtaylor113 and kyoto December 8, 2020 17:17

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020

andybraren approved these changes Dec 8, 2020

View reviewed changes

spadgett reviewed Dec 11, 2020

View reviewed changes

rhamilto force-pushed the bz1905253 branch from 385f62d to 64b7837 Compare December 11, 2020 21:09

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 11, 2020

rhamilto force-pushed the bz1905253 branch from 64b7837 to 0b9acd3 Compare December 11, 2020 21:19

rhamilto changed the title ~~Bug 1905253: update events timeline end message~~ Bug 1905253: update events timeline empty state and end messages Dec 11, 2020

rhamilto force-pushed the bz1905253 branch from 0b9acd3 to b147361 Compare December 22, 2020 16:18

openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 22, 2020

rhamilto force-pushed the bz1905253 branch from b147361 to 20d4aad Compare January 4, 2021 13:34

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2021

rhamilto force-pushed the bz1905253 branch from 20d4aad to 304d27c Compare January 4, 2021 13:40

Bug 1905253: update events timeline end message

1c28422

rhamilto force-pushed the bz1905253 branch from 304d27c to 1c28422 Compare January 4, 2021 13:44

spadgett approved these changes Jan 4, 2021

View reviewed changes

openshift-ci-robot assigned spadgett Jan 4, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2021

andybraren approved these changes Jan 4, 2021

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2021

openshift-merge-robot merged commit a8da4af into openshift:master Jan 5, 2021

rhamilto deleted the bz1905253 branch January 5, 2021 13:20

spadgett added this to the v4.7 milestone Jan 7, 2021

Bug 1905253: update events timeline empty state and end messages #7467

Bug 1905253: update events timeline empty state and end messages #7467

Conversation

rhamilto commented Dec 8, 2020 • edited

openshift-ci-robot commented Dec 8, 2020

rhamilto commented Dec 8, 2020

openshift-ci-robot commented Dec 8, 2020

andybraren left a comment

Choose a reason for hiding this comment

rhamilto commented Dec 8, 2020

rhamilto commented Dec 8, 2020

rhamilto commented Dec 8, 2020

spadgett Dec 11, 2020

Choose a reason for hiding this comment

rhamilto Dec 11, 2020

Choose a reason for hiding this comment

andybraren Dec 11, 2020 • edited

Choose a reason for hiding this comment

andybraren Dec 11, 2020 • edited

Choose a reason for hiding this comment

spadgett Dec 11, 2020

Choose a reason for hiding this comment

sttts Jan 4, 2021

Choose a reason for hiding this comment

openshift-ci-robot commented Dec 11, 2020

rhamilto commented Dec 22, 2020

spadgett left a comment

Choose a reason for hiding this comment

spadgett commented Jan 4, 2021

andybraren left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Jan 4, 2021

spadgett commented Jan 4, 2021

spadgett commented Jan 4, 2021

openshift-bot commented Jan 4, 2021

openshift-bot commented Jan 4, 2021

rhamilto commented Jan 4, 2021

openshift-bot commented Jan 4, 2021

openshift-bot commented Jan 4, 2021

openshift-bot commented Jan 5, 2021

openshift-bot commented Jan 5, 2021

openshift-bot commented Jan 5, 2021

openshift-bot commented Jan 5, 2021

openshift-bot commented Jan 5, 2021

openshift-bot commented Jan 5, 2021

openshift-bot commented Jan 5, 2021

openshift-ci bot commented Jan 5, 2021 • edited

openshift-bot commented Jan 5, 2021

openshift-bot commented Jan 5, 2021

openshift-ci-robot commented Jan 5, 2021

rhamilto commented Dec 8, 2020 •

edited

andybraren Dec 11, 2020 •

edited

andybraren Dec 11, 2020 •

edited

openshift-ci bot commented Jan 5, 2021 •

edited