Fix pvc to only have storageClass property if not null #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
@spadgett - this will probably have issues merging after PR751 goes in but I wanted to get the fix out there and I will rebase if needed. |
|
LGTM, you should be able to rebase now |
spadgett
approved these changes
Nov 7, 2018
|
/lgtm |
|
jenkins rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1647283
This code leaves the storageClasName property out of the definition for a new pvc if the value is null. Prior, we left the property in there with a null value which prevented the default storage class from being applied.