Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1913285: VM list empty state links to virtualization quick starts #7724

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Bug 1913285: VM list empty state links to virtualization quick starts #7724

merged 1 commit into from
Jan 8, 2021

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Jan 6, 2021

Screenshot from 2021-01-06 13-41-41

Screenshot from 2021-01-06 13-41-55

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references Bugzilla bug 1913285, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1913285: VM list empty state links to virtualization quick starts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels Jan 6, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
matthewcarleton
matthewcarleton reviewed Jan 6, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/src/components/vms/vm.tsx Outdated
variant="secondary"
onClick={() => history.push('/quickstart?keyword=virtual+machine')}
>
<RocketIcon className="co-icon-space-r" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be able to use the classes pf-c-button__icon pf-m-start to get the proper spacing

@rawagner rawagner force-pushed the quickstart_link branch 2 times, most recently from 4c08549 to 1a9fd6d Compare January 7, 2021 14:18
@yaacov
Copy link
Member

yaacov commented Jan 7, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 96f0cbe into openshift:master Jan 8, 2021
@openshift-ci-robot
Copy link
Contributor

@rawagner: All pull requests linked via external trackers have merged:

Bugzilla bug 1913285 has been moved to the MODIFIED state.

In response to this:

Bug 1913285: VM list empty state links to virtualization quick starts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewcarleton matthewcarleton matthewcarleton left review comments

@glekner glekner Awaiting requested review from glekner

@atiratree atiratree Awaiting requested review from atiratree

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.
7 participants
@rawagner @openshift-ci-robot @yaacov @openshift-bot @matthewcarleton @spadgett @openshift-merge-robot