Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1902003: Clarification of Jobs completions column data when sorting #7760

Merged
merged 1 commit into from Feb 10, 2021
Merged

Bug 1902003: Clarification of Jobs completions column data when sorting #7760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/public/components/factory/table.tsx
View file
Open in desktop
Expand Up @@ -131,7 +131,7 @@ const sorts = {
dataSize: (resource) => _.size(_.get(resource, 'data')) + _.size(_.get(resource, 'binaryData')),
ingressValidHosts,
serviceCatalogStatus,
jobCompletions: (job) => getJobTypeAndCompletions(job).completions,
jobCompletionsSucceeded: (job) => job?.status?.succeeded || 0,
jobType: (job) => getJobTypeAndCompletions(job).type,
nodeReadiness: (node: NodeKind) => {
let readiness = _.get(node, 'status.conditions');
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/components/job.tsx
View file
Open in desktop
Expand Up @@ -217,7 +217,7 @@ const JobsList: React.FC = (props) => {
},
{
title: t('public~Completions'),
sortFunc: 'jobCompletions',
sortFunc: 'jobCompletionsSucceeded',
transforms: [sortable],
props: { className: tableColumnClasses[3] },
},
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/components/machine-set.tsx
View file
Open in desktop
Expand Up @@ -271,7 +271,7 @@ export const MachineSetList: React.SFC = (props) => {
},
{
title: t('machine-sets~Machines'),
sortField: 'status.replicas',
sortField: 'status.readyReplicas',
transforms: [sortable],
props: { className: tableColumnClasses[2] },
},
Expand Down