Bug 1902003: Clarification of Jobs completions column data when sorting

[sg00dwin]

https://bugzilla.redhat.com/show_bug.cgi?id=1902003 was opened regarding “Incorrect” sorting of the Job Completions column. The column data is sorting correctly on desired {completions} but the content is presented as {succeeded} of {completions} (eg 1 of 1) . When sorted descending order, the following visually looks incorrect listed as, 2 of 20, 3 of 8, 1 of 1.
To alleviate this confusion I suggest we include stack the Desired {completions} above Succeeded {job.status.succeeded || 0}.

[rebeccaalpert]

Thanks for making that change.

[spadgett]

If we're going to do this, would it be better to simply make them separate columns? Then you could sort either by successful or total.

[sg00dwin]

If we're going to do this, would it be better to simply make them separate columns? Then you could sort either by successful or total.

I assume it would depend on how valuable it is to be able to sort by most currently succeeded is vs the additional space constraints. Personally I think the stacking of the two works well from a content presentation scanning perspective.

[spadgett]

cc @beanh66 for UX input

[openshift-ci-robot]

@sg00dwin: This pull request references Bugzilla bug 1902003, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1902003: Clarification of Jobs completions column data when sorting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cshinn]

Does every column need to be sortable? The initial format is concise and pretty clear and takes less space than separate columns would

[sg00dwin]

Does every column need to be sortable? The initial format is concise and pretty clear and takes less space than separate columns would

Columns don't necessarily need to be sortable, though it seems like a reasonable data to sort by.

[spadgett]

I was wondering if we shouldn't just change the sort to use the first number (succeeded) instead of desired

[beanh66]

That was my initial thought as well @spadgett. The column header even makes me think that's what is being displayed anyways since Completed may imply "successfully completed."

For what it's worth, for Pods we have a column called "Ready" and then we have x of y and we seem to sort on the first number. Machine sets on the other hand seem to have the same problem as jobs, where we sorting on the second number and maybe should change to sort on the first.

[sg00dwin]

I have updated this pr to sort by Succeeded Completions and reverted to display the original "x of y".

[spadgett]

@sg00dwin Thanks, can you look at updating the MachineSet sort as well?

[sg00dwin]

/retest

[sg00dwin]

/retest

[spadgett]

/override ci/prow/ceph-storage-plugin

The ceph-storage-plugin job should only have run on PRs with changes to frontend/packages/ceph-storage-plugin. It failed due to an unrelated CI config change. Overriding status on this PR.

[openshift-ci-robot]

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/ceph-storage-plugin

In response to this:

/override ci/prow/ceph-storage-plugin

The ceph-storage-plugin job should only have run on PRs with changes to frontend/packages/ceph-storage-plugin. It failed due to an unrelated CI config change. Overriding status on this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sg00dwin]

/retest

[sg00dwin]

@spadgett pr updated to include sorting MachineSet Machines by ready vs desired

[sg00dwin]

/retest

[sg00dwin]

/retest

[spadgett]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@sg00dwin: All pull requests linked via external trackers have merged:

• openshift/console#7760

Bugzilla bug 1902003 has been moved to the MODIFIED state.

In response to this:

Bug 1902003: Clarification of Jobs completions column data when sorting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.