Bug 1914427: Use kube_running_pod_ready to exclude terminal pods #7779
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@smarterclayton: This pull request references Bugzilla bug 1914427, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
lgtm
Terminal pods have no cost to the system in most scenarios, so our dashboards and queries should exclude metrics that include terminal pods (which `kube_pod_info` includes). The new 4.7 metric `kube_running_pod_ready` only includes non-terminal pods and is the appropriate metric to display for counts and joins to used capacity. On the dashboard this means the pod count reflects the running state of the system, not completed pods which could be in the thousands and have minimal overhead.
smarterclayton
force-pushed
the
console
branch
from
3412846
to
75255c7
Compare
|
one more change (forgot to save the file) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@smarterclayton: All pull requests linked via external trackers have merged: Bugzilla bug 1914427 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
FYI @openshift/openshift-team-monitoring |
Terminal pods have no cost to the system in most scenarios, so
our dashboards and queries should exclude metrics that include
terminal pods (which
kube_pod_infoincludes). The new 4.7 metrickube_running_pod_readyonly includes non-terminal pods and isthe appropriate metric to display for counts and joins to used
capacity. On the dashboard this means the pod count reflects the
running state of the system, not completed pods which could be
in the thousands and have minimal overhead.