Bug 1891766: Stop non-positive values from being entered by users for min disk size

[SanjalKatiyar]

Before:

After:

[openshift-ci-robot]

@SanjalKatiyar: This pull request references Bugzilla bug 1891766, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1891766: Stop non-positive values from being entered by users for min disk size

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

Hi @SanjalKatiyar. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SanjalKatiyar]

/bugzilla refresh

[openshift-ci-robot]

@SanjalKatiyar: This pull request references Bugzilla bug 1891766, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bipuladh]

/bugzilla refresh

[openshift-ci-robot]

@bipuladh: This pull request references Bugzilla bug 1891766, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bipuladh]

Suggested change

	const validMinDiskSize = /^\+?([1-9]\d*)$/.test(state.minDiskSize || '1');
	const validMaxDiskSize = /^\+?([1-9]\d*)$/.test(state.maxDiskSize || '1');
	const validMaxDiskLimit = /^\+?([1-9]\d*)$/.test(state.maxDiskLimit || '1');
	const INTEGER_REGEX = /^\+?([1-9]\d*)$/;
	const validMinDiskSize = INTEGER_REGEX.test(state.minDiskSize || '1');
	const validMaxDiskSize = INTEGER_REGEX.test(state.maxDiskSize || '1');
	const validMaxDiskLimit = INTEGER_REGEX.test(state.maxDiskLimit || '1');

[cloudbehl]

I think the minimum size for a disk can be 0 as well.

Also, I think we need to put one more validation where the value to max disk size should be bigger than the value of min disk size.

@bipuladh ^^

[bipuladh]

I agree with you @cloudbehl . @SanjalKatiyar I guess we will need two regex patterns. One that accepts 0 and the other one that doesn't.
Also we should definitely give a warning in max value/min value based on which one is active so that user doesn't shoot himself in the foot.
@yuvalgalanti wdyt?

[bipuladh]

Let's remove this as well and use the other class.

[SanjalKatiyar]

Okay... using single class for min disk size, max disk size and max disk limit...

[bipuladh]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/local-storage-operator-plugin/OWNERS [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bipuladh]

/hold
Backend tests are failing

[bipuladh]

/hold cancel
/test backend

[bipuladh]

/retest
/test ceph-storage-plugin

[openshift-ci-robot]

@SanjalKatiyar: All pull requests linked via external trackers have merged:

• openshift/console#7890

Bugzilla bug 1891766 has been moved to the MODIFIED state.

In response to this:

Bug 1891766: Stop non-positive values from being entered by users for min disk size

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.