Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1893889: Update pf dependencies to 2021-1 to fix a117 issues with disabled dropdown items #7899

Merged
merged 1 commit into from Jan 29, 2021
Merged

Bug 1893889: Update pf dependencies to 2021-1 to fix a117 issues with disabled dropdown items #7899

merged 1 commit into from Jan 29, 2021

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Jan 21, 2021 •
edited

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1893889

Updates pf dependencies to release 2021.1

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1893889, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1893889: Update pf dependencies to 2020-16 to fix a117 issues with disabled dropdown items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality labels Jan 21, 2021
@openshift-ci-robot openshift-ci-robot added the component/monitoring Related to monitoring label Jan 21, 2021
@jcaianirh jcaianirh mentioned this pull request Jan 21, 2021
Closed
@spadgett
Copy link
Member

/assign @rhamilto

@rhamilto Can you help validate these changes?

@jcaianirh Please squash, thanks!

@rhamilto
Copy link
Member

/assign @rhamilto

@rhamilto Can you help validate these changes?

Pulled PR and tested. Everything looks good to me. Just need @jcaianirh to squash.

@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2021
@jcaianirh
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jcaianirh
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jcaianirh
Copy link
Member Author

Looks like there is an issue with the table action column which outputs an empty scope attribute. Added a pf issue here: patternfly/patternfly-react#5373 which is causing the cypress a11y tests to fail

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2021
@jcaianirh
Copy link
Member Author

/hold
until above issue is resolved

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2021
@jcaianirh
Copy link
Member Author

jcaianirh commented Jan 25, 2021 •
edited

Updated with latest prerelease packages for 2020.17 which addresses fix for broken a11y cypress test (tested locally). Keeping hold on pr until pf officially releases (probably pending no issues 1/26/2021)

@jcaianirh
Copy link
Member Author

/retest

@jcaianirh
Copy link
Member Author

@rhamilto new pf dependencies added for this pr if you wanna take another look

rhamilto
rhamilto approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 26, 2021
@jcaianirh jcaianirh changed the title Bug 1893889: Update pf dependencies to 2020-16 to fix a117 issues with disabled dropdown items Bug 1893889: Update pf dependencies to 2020-17 to fix a117 issues with disabled dropdown items Jan 27, 2021
@jcaianirh jcaianirh changed the title Bug 1893889: Update pf dependencies to 2020-17 to fix a117 issues with disabled dropdown items Bug 1893889: Update pf dependencies to 2021-1 to fix a117 issues with disabled dropdown items Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1893889, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1893889: Update pf dependencies to 2021-1 to fix a117 issues with disabled dropdown items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaianirh
Copy link
Member Author

/retest

@jcaianirh
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0cc2132 into openshift:master Jan 29, 2021
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: All pull requests linked via external trackers have merged:

Bugzilla bug 1893889 has been moved to the MODIFIED state.

In response to this:

Bug 1893889: Update pf dependencies to 2021-1 to fix a117 issues with disabled dropdown items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@rhamilto rhamilto rhamilto approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jcaianirh @openshift-ci-robot @spadgett @rhamilto @openshift-bot @openshift-merge-robot