Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Table action row headers now output the scope attribute with no assignment breaking cypress a11y tests #5373

Closed
jcaianirh opened this issue Jan 25, 2021 · 2 comments

Comments

@jcaianirh
Copy link
Contributor

Describe the issue. What is the expected and unexpected behavior?
PF Table action row headers such as this example:
https://www.patternfly.org/v4/components/table#actions-and-first-cell-in-body-rows-as-th
output a scope attribute that has no assignment causing this a11y test to fail:
https://dequeuniversity.com/rules/axe/3.4/scope-attr-valid?application=axeAPI
This is breaking openshift cypress a11y tests and causing us not to be able to upgrade.
Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.

https://www.patternfly.org/v4/components/table#actions-and-first-cell-in-body-rows-as-th
inspect the action row and see there is an empty scope
Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
bug
What is your product and what release version are you targeting?
openshift 4.7

@jcaianirh
Copy link
Contributor Author

This bug was introduced in 2020.15, you can see that in 2020.14 the extra scope attribute does not exist here:
https://www.patternfly.org/2020.14/components/table/#simple-actions

@tlabaj
Copy link
Contributor

tlabaj commented Mar 16, 2021

closed by #5253

@tlabaj tlabaj closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants