-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1921806: i18n APIResourceLinks #7969
Bug 1921806: i18n APIResourceLinks #7969
Conversation
APIResourceLinks may not match navigation and other references to kinds. I updated them to use keys where available. Note that the schema information has not been internationalized so the descriptions will reference the English terms. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1921806
@rebeccaalpert: This pull request references Bugzilla bug 1921806, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rebeccaalpert: All pull requests linked via external trackers have merged: Bugzilla bug 1921806 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
APIResourceLinks in the Explore page may not match navigation and other references to kinds. I updated them to use modal labelKeys where available instead of the kind. The fallback is the kind as originally laid out.
Note that the schema information has not been internationalized, so the descriptions that are closely associated to these in the Explore section will reference the English terms. That content is not hard-coded in the front-end, but we should look into getting that internationalized if we're externalizing Kubernetes kinds.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1921806.