[release-4.7] Bug 1928023: Consider finally tasks when calculating task status #8149

rottencandy · 2021-02-12T07:32:59Z

This is a cherry-pick of #8110

openshift-ci-robot · 2021-02-12T07:33:04Z

@rottencandy: This pull request references Bugzilla bug 1928023, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1926843 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2021-02-12T07:35:14Z

/cc @andrewballantyne

rottencandy · 2021-02-12T08:05:08Z

/bugzilla refresh

openshift-ci-robot · 2021-02-12T08:05:11Z

@rottencandy: This pull request references Bugzilla bug 1928023, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1926843 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2021-02-12T08:32:32Z

/bugzilla refresh

openshift-ci-robot · 2021-02-12T08:32:35Z

@rottencandy: This pull request references Bugzilla bug 1928023, which is invalid:

expected dependent Bugzilla bug 1926843 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne

/lgtm

We have moved types in 4.8, which caused the conflict. Same implementation as 4.8.

andrewballantyne · 2021-02-12T16:04:03Z

/retest

openshift-ci-robot · 2021-02-12T16:04:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/pipelines-plugin/OWNERS~~ [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-02-12T18:05:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-12T20:28:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-12T23:04:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-13T00:48:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-13T01:00:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-13T01:00:17Z

@openshift-bot: This pull request references Bugzilla bug 1928023, which is invalid:

expected dependent Bugzilla bug 1926843 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-13T02:45:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-13T04:16:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-13T06:13:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-13T07:44:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-13T09:28:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-13T11:38:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-16T03:19:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-16T05:03:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-16T06:34:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-16T08:18:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-16T10:28:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-16T12:25:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

andrewballantyne · 2021-02-16T14:08:35Z

/hold

Waiting on #8109 to merge before tests can pass.

rottencandy · 2021-02-22T06:20:36Z

/bugzilla refresh

openshift-ci-robot · 2021-02-22T06:20:39Z

@rottencandy: This pull request references Bugzilla bug 1928023, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1926843 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karthikjeeyar · 2021-02-22T07:40:27Z

/bugzilla refresh

openshift-ci-robot · 2021-02-22T07:40:30Z

@karthikjeeyar: This pull request references Bugzilla bug 1928023, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2021-02-25T11:16:58Z

/bugzilla refresh

openshift-ci-robot · 2021-02-25T11:17:24Z

@rottencandy: This pull request references Bugzilla bug 1928023, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1926843 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1926843 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2021-02-25T15:21:29Z

/hold cancel
/retest

openshift-bot · 2021-02-25T15:52:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-03T02:55:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-03T03:21:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-03-03T04:24:23Z

@rottencandy: All pull requests linked via external trackers have merged:

openshift/console#8149

Bugzilla bug 1928023 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-03-03T04:25:11Z

@rottencandy: #8149 failed to apply on top of branch "release-4.6":

Applying: consider finally tasks when calculating status
Using index info to reconstruct a base tree...
A	frontend/packages/pipelines-plugin/src/test-data/pipeline-data.ts
A	frontend/packages/pipelines-plugin/src/utils/__tests__/pipeline-augment.spec.ts
A	frontend/packages/pipelines-plugin/src/utils/pipeline-augment.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/utils/pipeline-augment.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/utils/pipeline-augment.ts
Auto-merging frontend/packages/dev-console/src/utils/__tests__/pipeline-augment.spec.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/utils/__tests__/pipeline-augment.spec.ts
Auto-merging frontend/packages/dev-console/src/test/pipeline-data.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/test/pipeline-data.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 consider finally tasks when calculating status
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2021-03-03T16:04:27Z

/bugzilla refresh

openshift-ci-robot · 2021-03-03T16:04:29Z

@rottencandy: Bugzilla bug 1928023 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

consider finally tasks when calculating status

2fba920

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 12, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 12, 2021

openshift-ci-robot requested review from karthikjeeyar and rohitkrai03 February 12, 2021 07:33

openshift-ci-robot requested a review from andrewballantyne February 12, 2021 07:35

andrewballantyne approved these changes Feb 12, 2021

View reviewed changes

openshift-ci-robot assigned andrewballantyne Feb 12, 2021

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 12, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 25, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 25, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021

spadgett added this to the v4.7.z milestone Mar 1, 2021

mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 2, 2021

openshift-merge-robot merged commit d4e847a into openshift:release-4.7 Mar 3, 2021

rottencandy mentioned this pull request Mar 3, 2021

Bug 1934664: Consider finally tasks when calculating task status #8292

Merged

rottencandy deleted the plfinallystatus-4.7 branch May 26, 2021 15:32

[release-4.7] Bug 1928023: Consider finally tasks when calculating task status #8149

[release-4.7] Bug 1928023: Consider finally tasks when calculating task status #8149

Conversation

rottencandy commented Feb 12, 2021

openshift-ci-robot commented Feb 12, 2021

rottencandy commented Feb 12, 2021

rottencandy commented Feb 12, 2021

openshift-ci-robot commented Feb 12, 2021

rottencandy commented Feb 12, 2021

openshift-ci-robot commented Feb 12, 2021

andrewballantyne left a comment

Choose a reason for hiding this comment

andrewballantyne commented Feb 12, 2021

openshift-ci-robot commented Feb 12, 2021

openshift-bot commented Feb 12, 2021

openshift-bot commented Feb 12, 2021

openshift-bot commented Feb 12, 2021

openshift-bot commented Feb 13, 2021

openshift-bot commented Feb 13, 2021

openshift-ci-robot commented Feb 13, 2021

openshift-bot commented Feb 13, 2021

openshift-bot commented Feb 13, 2021

openshift-bot commented Feb 13, 2021

openshift-bot commented Feb 13, 2021

openshift-bot commented Feb 13, 2021

openshift-bot commented Feb 13, 2021

openshift-bot commented Feb 16, 2021

openshift-bot commented Feb 16, 2021

openshift-bot commented Feb 16, 2021

openshift-bot commented Feb 16, 2021

openshift-bot commented Feb 16, 2021

openshift-bot commented Feb 16, 2021

andrewballantyne commented Feb 16, 2021

rottencandy commented Feb 22, 2021

openshift-ci-robot commented Feb 22, 2021

karthikjeeyar commented Feb 22, 2021

openshift-ci-robot commented Feb 22, 2021

rottencandy commented Feb 25, 2021

openshift-ci-robot commented Feb 25, 2021

spadgett commented Feb 25, 2021

openshift-bot commented Feb 25, 2021

openshift-bot commented Mar 3, 2021

openshift-bot commented Mar 3, 2021

openshift-ci-robot commented Mar 3, 2021

openshift-cherrypick-robot commented Mar 3, 2021

rottencandy commented Mar 3, 2021

openshift-ci-robot commented Mar 3, 2021