Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1928045: Fixes N+1 scaling info #8217

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Bug 1928045: Fixes N+1 scaling info #8217

merged 1 commit into from
Feb 23, 2021

Conversation

Jayashree-panda
Copy link
Contributor

Signed-off-by: Jayashree-panda jayashreepanda12345@gmail.com

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 23, 2021
@openshift-ci-robot
Copy link
Contributor

@Jayashree-panda: This pull request references Bugzilla bug 1928045, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1928045: Fixes N+1 scaling info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2021
@openshift-ci-robot
Copy link
Contributor

Hi @Jayashree-panda. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23
afreen23 suggested changes Feb 23, 2021
View reviewed changes
frontend/packages/ceph-storage-plugin/src/utils/common-ocs-install-el.tsx Outdated
@@ -123,7 +123,7 @@ export const VALIDATIONS = (type: keyof typeof ValidationType, t: TFunction): Va
return {
variant: AlertVariant.info,
title: t(
'ceph-storage-plugin~When all the selected nodes in the storage class are in a single zone the cluster will be using a host-based failure domain.',
'ceph-storage-plugin~When the nodes in the selected storage class are spread across fewer than 3 availability zones, the storage cluster will be deployed with the host failure domain.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'ceph-storage-plugin~When the nodes in the selected storage class are spread across fewer than 3 availability zones, the storage cluster will be deployed with the host failure domain.',
'ceph-storage-plugin~When the nodes in the selected storage class are spread across fewer than 3 availability zones, the storage cluster will be deployed with the host based failure domain.',

@afreen23
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2021
@Jayashree-panda
Fixes N+1 scaling info
0cae965 
Signed-off-by: Jayashree-panda <jayashreepanda12345@gmail.com>
afreen23
afreen23 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, Jayashree-panda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d50368b into openshift:master Feb 23, 2021
@openshift-ci-robot
Copy link
Contributor

@Jayashree-panda: All pull requests linked via external trackers have merged:

Bugzilla bug 1928045 has been moved to the MODIFIED state.

In response to this:

Bug 1928045: Fixes N+1 scaling info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.8 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 afreen23 approved these changes

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.
6 participants
@Jayashree-panda @openshift-ci-robot @afreen23 @openshift-bot @spadgett @openshift-merge-robot