Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for creating single namespace store bucket class #8266

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Adds support for creating single namespace store bucket class #8266

merged 1 commit into from
Apr 5, 2021

Conversation

vbnrh
Copy link
Contributor

@vbnrh vbnrh commented Mar 1, 2021 •
edited
Loading

Depends on #8223. Please review the commit for single-namespace store bucket class
Issue Link: https://issues.redhat.com/browse/RHSTOR-1653
Designs: https://marvelapp.com/prototype/fa616je/screen/74336152

How to test
Use OCS image: quay.io/vbnrh/ocs-registry:nooba-namespace-store-2
along with this PR

All screenshots taken on an ultra wide monitor hence may seem stretched out

Screenshot from 2021-03-02 11-00-12
Screenshot from 2021-03-02 10-56-23
Screenshot from 2021-03-02 10-56-39
Screenshot from 2021-03-02 10-56-47
Screenshot from 2021-03-02 10-56-54
Screenshot from 2021-03-02 10-56-59

@openshift-ci-robot openshift-ci-robot added the component/noobaa Related to noobaa-storage-plugin label Mar 1, 2021
@openshift-ci-robot openshift-ci-robot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Mar 1, 2021
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology labels Mar 1, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2021
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2021
@vbnrh
Copy link
Contributor Author

vbnrh commented Mar 2, 2021

/test ceph-storage-plugin

@vbnrh vbnrh mentioned this pull request Mar 3, 2021
Merged
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2021
afreen23
afreen23 suggested changes Mar 25, 2021
View reviewed changes
frontend/packages/ceph-storage-plugin/src/components/bucket-class/create-bc.scss Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/create-bc.scss Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/review-utils.tsx Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/wizard-pages/general-page.tsx Outdated Show resolved Hide resolved
...kages/ceph-storage-plugin/src/components/bucket-class/wizard-pages/namespace-policy-page.tsx Outdated Show resolved Hide resolved
...end/packages/ceph-storage-plugin/src/components/namespace-store/namespace-store-dropdown.tsx Outdated Show resolved Hide resolved
...end/packages/ceph-storage-plugin/src/components/namespace-store/namespace-store-dropdown.tsx Outdated Show resolved Hide resolved
...end/packages/ceph-storage-plugin/src/components/namespace-store/namespace-store-dropdown.tsx Outdated Show resolved Hide resolved
...end/packages/ceph-storage-plugin/src/components/namespace-store/namespace-store-dropdown.tsx Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/constants/providers.ts Outdated Show resolved Hide resolved
afreen23
afreen23 suggested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check and fix all such occurrences
Backing Store -> BackingStore
Namespace Store -> NamespaceStore
Bucket Class -> BucketClass

  • use sentence case for form labels

frontend/packages/ceph-storage-plugin/src/components/bucket-class/wizard-pages/review-page.tsx Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/wizard-pages/review-page.tsx Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/wizard-pages/review-page.tsx Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/wizard-pages/review-page.tsx Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/wizard-pages/review-page.tsx Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/wizard-pages/review-page.tsx Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2021
@vbnrh vbnrh force-pushed the nns-bucket-class-page branch 3 times, most recently from cdd06ec to 4d8b552 Compare March 25, 2021 16:09
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2021
@vbnrh vbnrh force-pushed the nns-bucket-class-page branch 2 times, most recently from 7ef8e32 to cbb2d78 Compare March 29, 2021 06:11
@vbnrh vbnrh force-pushed the nns-bucket-class-page branch 2 times, most recently from df6f4a3 to 258a430 Compare March 30, 2021 16:21
bipuladh
bipuladh suggested changes Mar 31, 2021
View reviewed changes
frontend/packages/noobaa-storage-plugin/src/constants/providers.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/backingstore-table.tsx Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/create-bc.scss Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/create-bc.scss Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/bucket-class/create-bc.scss Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/namespace-store/create-namespace-store.tsx Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/constants/bucket-class.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/constants/bucket-class.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/constants/bucket-class.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/utils/bucket-class.ts Outdated Show resolved Hide resolved
@vbnrh vbnrh force-pushed the nns-bucket-class-page branch 2 times, most recently from b81b108 to 5a7dded Compare April 1, 2021 06:41
@vbnrh
Adds support for creating single namespace bucket class
31f0d34 
Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
@vbnrh
Copy link
Contributor Author

vbnrh commented Apr 1, 2021

/test ceph-storage-plugin

@bipuladh
Copy link
Contributor

bipuladh commented Apr 5, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 01abeae into openshift:master Apr 5, 2021
@spadgett spadgett added this to the v4.8 milestone Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl cloudbehl left review comments

@afreen23 afreen23 afreen23 requested changes

@bipuladh bipuladh bipuladh requested changes

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/noobaa Related to noobaa-storage-plugin component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.
7 participants
@vbnrh @bipuladh @openshift-ci-robot @cloudbehl @afreen23 @spadgett @openshift-merge-robot