Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-5596-Updated cypress extensibility related files #8305

Merged
merged 1 commit into from Mar 9, 2021
Merged

ODC-5596-Updated cypress extensibility related files #8305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/.gherkin-lintrc
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"no-empty-file": "on",
"no-scenario-outlines-without-examples": "on",
"name-length": "off",
"allowed-tags": ["on", {"tags": ["@manual", "@regression", "@smoke", "@add-flow", "@topology", "@knative", "@guided-tour", "@gitops", "@helm", "@monitoring", "@pipelines", "@virtualization", "@web-terminal", "@vulnerability"]}],
"allowed-tags": ["on", {"tags": ["@manual", "@regression", "@smoke", "@add-flow", "@topology", "@knative", "@guided-tour", "@gitops", "@helm", "@monitoring", "@pipelines", "@virtualization", "@web-terminal", "@vulnerability", "@knative-eventing", "@knative-camelK", "@kafka"]}],
"no-restricted-tags": ["on", {"tags": ["@watch", "@wip", "@debug", "@to-do"]}],
"use-and": "off",
"no-duplicate-tags": "on",
Expand All @@ -23,5 +23,6 @@
"no-background-only-scenario": "on",
"no-empty-background": "on",
"scenario-size": ["on", { "steps-length": {"Background": 5, "Scenario": 15}}],
"max-scenarios-per-file": ["on", {"maxScenarios": 10, "countOutlineExamples": true}]
"max-scenarios-per-file": ["on", {"maxScenarios": 15, "countOutlineExamples": true}],
"file-name": ["on", {"style": "kebab-case"}]
}
8 changes: 7 additions & 1 deletion frontend/package.json
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@
"coverage": "jest --coverage .",
"eslint": "eslint --ext .js,.jsx,.ts,.tsx,.json,.gql,.graphql --color",
"lint": "NODE_OPTIONS=--max-old-space-size=4096 yarn eslint .",
"gherkin-lint": "./node_modules/.bin/gherkin-lint -c ./.gherkin-lintrc ./packages/dev-console/integration-tests/features",
"gherkin-lint": "./node_modules/.bin/gherkin-lint -c ./.gherkin-lintrc ./packages/*/integration-tests/features",
"test": "jest",
"debug-test": "node --inspect-brk node_modules/.bin/jest --runInBand",
"webdriver-update": "webdriver-manager update",
Expand All @@ -39,6 +39,12 @@
"test-cypress-ceph-headless": "cd packages/ceph-storage-plugin/integration-tests-cypress && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --config-file cypress-ceph.json --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless",
"test-cypress-kubevirt": "cd packages/kubevirt-plugin/integration-tests-cypress && ../../../node_modules/.bin/cypress open --env openshift=true",
"test-cypress-kubevirt-headless": "cd packages/kubevirt-plugin/integration-tests-cypress && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless",
"test-cypress-pipelines": "cd packages/pipelines-plugin/integration-tests && ../../../node_modules/.bin/cypress open --env openshift=true",
"test-cypress-pipelines-headless": "cd packages/pipelines-plugin/integration-tests && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless --spec \"features/*/*.feature\";",
"test-cypress-gitops": "cd packages/gitops-plugin/integration-tests && ../../../node_modules/.bin/cypress open --env openshift=true",
"test-cypress-gitops-headless": "cd packages/gitops-plugin/integration-tests && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless --spec \"features/*/*.feature\";",
"test-cypress-knative": "cd packages/knative-plugin/integration-tests && ../../../node_modules/.bin/cypress open --env openshift=true",
"test-cypress-knative-headless": "cd packages/knative-plugin/integration-tests && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless --spec \"features/*/*.feature\";",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, are any of these supposed to run during CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Dave, below are the scripts needs to be executed on CI, but I don't want to run them on all pr's
test-cypress-gitops-headless [This should run, only when gitOps label is added to the pr]
test-cypress-knative-headless [This should run, only when knative label is added to the pr]
I will raise this ci implementation as separate pr

"cypress-merge": "mochawesome-merge ./gui_test_screenshots/cypress_report*.json > ./gui_test_screenshots/cypress.json",
"cypress-generate": "marge -o ./gui_test_screenshots/ -f cypress-report -t 'OpenShift Console Cypress Test Results' -p 'OpenShift Cypress Test Results' --showPassed false --assetsDir ./gui_test_screenshots/cypress/assets ./gui_test_screenshots/cypress.json",
"cypress-a11y-report": "echo '\nA11y Test Results:' && mv packages/integration-tests-cypress/cypress-a11y-report.json ./gui_test_screenshots/ && node -e \"console.table(JSON.parse(require('fs').readFileSync(process.argv[1])));\" ./gui_test_screenshots/cypress-a11y-report.json",
Expand Down
1 change: 1 addition & 0 deletions frontend/packages/gitops-plugin/integration-tests/OWNERS
View file
Open in desktop
@@ -1,5 +1,6 @@
reviewers:
- gajanan-more
- sanketpathak
- amitkrout
approvers:
- makambalaji
1 change: 1 addition & 0 deletions frontend/packages/knative-plugin/integration-tests/OWNERS
View file
Open in desktop
@@ -1,5 +1,6 @@
reviewers:
- gajanan-more
- sanketpathak
- mgencur
approvers:
- makambalaji
2 changes: 2 additions & 0 deletions frontend/packages/pipelines-plugin/integration-tests/OWNERS
View file
Open in desktop
@@ -1,5 +1,7 @@
reviewers:
- gajanan-more
- sanketpathak
- VeereshAradhya
- praveen4g0
approvers:
- makambalaji