Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1936801: support service binding operator version 0.5.0 #8309

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Mar 5, 2021

Fixes: https://issues.redhat.com/browse/ODC-5535

Analysis / Root cause: API group name is changed in service binding operator version 0.5

Solution Description: update the API group for service binding operator

Screen shots / Gifs for design review:

sb-0 5

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@sahil143
Copy link
Contributor Author

sahil143 commented Mar 5, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot

@sahil143: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohitkrai03
Copy link
Contributor

/retest

@rohitkrai03
Copy link
Contributor

/assign

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1713f11 into openshift:master Mar 8, 2021
@openshift-cherrypick-robot

@sahil143: new pull request created: #8327

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sahil143 sahil143 changed the title support service binding operator version 0.5.0 Bug 1936801: support service binding operator version 0.5.0 Mar 9, 2021
@openshift-ci-robot
Copy link
Contributor

@sahil143: All pull requests linked via external trackers have merged:

Bugzilla bug 1936801 has been moved to the MODIFIED state.

In response to this:

Bug 1936801: support service binding operator version 0.5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sahil143
Copy link
Contributor Author

sahil143 commented Mar 9, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot

@sahil143: new pull request created: #8335

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/topology Related to topology lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants