Add form component for editing deployments #8401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/feature
openshift-ci-robot
added
component/dev-console
frontend/packages/dev-console/src/components/edit-deployment/AdvancedSection.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/edit-deployment/EditDeploymentFormEditor.tsx
Show resolved
Hide resolved
...packages/dev-console/src/components/edit-deployment/deployment-strategy/RecreateStrategy.tsx
Show resolved
Hide resolved
divyanshiGupta
force-pushed
the
ODC-5453
branch
2 times, most recently
from
4b3650d
to
871ca42
Compare
divyanshiGupta
force-pushed
the
ODC-5453
branch
from
871ca42
to
79a6bc1
Compare
rohitkrai03
approved these changes
Mar 18, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/ODC-5453
In this PR I have added a form component that will be used for editing the deployments.
This form will be integrated into edit-deployment feature in this story https://issues.redhat.com/browse/ODC-5454.
During integration I will be refactoring a few components like
HealthCheckProbes,ImageSearchSection,SourceSecretSelectorand make them generic so that they can be used for this form as well and we don't have duplicate any code. Any other remaining issues in the form (if any) will be fixed in the upcoming story./kind feature