Pool management - delete #8550

GowthamShanmugam · 2021-04-04T13:56:12Z

Signed-off-by: Gowtham Shanmugasundaram gshanmug@redhat.com

GowthamShanmugam · 2021-04-04T13:57:20Z

frontend/packages/ceph-storage-plugin/src/types.ts

+
+export type OcsStorageClassResource = StorageClassResourceKind & {
+  parameters: {
+    pool: string;


existing storage kind dont have StorageClassResourceKind dont have a parameter, also parameter will change dynamically, i am maintaining our OCS specific StorageClassResourceKind

GowthamShanmugam · 2021-04-04T13:57:48Z

GowthamShanmugam · 2021-04-05T15:17:57Z

/retest

GowthamShanmugam · 2021-04-05T17:45:40Z

/retest

afreen23 · 2021-04-06T05:57:22Z

frontend/packages/ceph-storage-plugin/locales/en/ceph-storage-plugin.json

  "Finish": "Finish",
+  "Delete Block Pool": "Delete Block Pool",
+  "{state.poolStatus === POOL_PROGRESS.BOUNDED ? (\n                  <p>\n                    <strong>{state.poolName}</strong> cannot be deleted. When a pool is bounded to\n                    PVC it cannot be deleted. Please detach all the resources from storage class(es){' '}\n                    <strong>{scNames.join(', ')}</strong>.{' '}\n                    <Button variant=\"link\" isInline onClick={pvcLink}>\n                      Go to PVC list\n                    </Button>\n                  </p>\n                ) : (\n                  <p>\n                    Deleting <strong>{state.poolName}</strong> will remove all the saved data of\n                    this pool. Are you sure want to delete?\n                  </p>\n                )}": "{state.poolStatus === POOL_PROGRESS.BOUNDED ? (\n                  <p>\n                    <strong>{state.poolName}</strong> cannot be deleted. When a pool is bounded to\n                    PVC it cannot be deleted. Please detach all the resources from storage class(es){' '}\n                    <strong>{scNames.join(', ')}</strong>.{' '}\n                    <Button variant=\"link\" isInline onClick={pvcLink}>\n                      Go to PVC list\n                    </Button>\n                  </p>\n                ) : (\n                  <p>\n                    Deleting <strong>{state.poolName}</strong> will remove all the saved data of\n                    this pool. Are you sure want to delete?\n                  </p>\n                )}",


This is probably by mistake ?

afreen23 · 2021-04-06T06:37:53Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+              <Trans t={t} ns="ceph-storage-plugin">
+                {state.poolStatus === POOL_PROGRESS.BOUNDED ? (
+                  <p>
+                    <strong>{state.poolName}</strong> cannot be deleted. When a pool is bounded to
+                    PVC it cannot be deleted. Please detach all the resources from storage class(es){' '}
+                    <strong>{scNames.join(', ')}</strong>.{' '}
+                    <Button variant="link" isInline onClick={pvcLink}>
+                      Go to PVC list
+                    </Button>
+                  </p>


Suggested change

<Trans t={t} ns="ceph-storage-plugin">

{state.poolStatus === POOL_PROGRESS.BOUNDED ? (



{state.poolName} cannot be deleted. When a pool is bounded to

PVC it cannot be deleted. Please detach all the resources from storage class(es){' '}

{scNames.join(', ')}.{' '}

<Button variant="link" isInline onClick={pvcLink}>

Go to PVC list

</Button>



{state.poolStatus === POOL_PROGRESS.BOUNDED ? (

<Trans t={t} ns="ceph-storage-plugin">



{{state.poolName}} cannot be deleted. When a pool is bounded to

PVC it cannot be deleted. Please detach all the resources from storage class(es){' '}

{{scNames.join(', ')}}.{' '}

<Button variant="link" isInline onClick={pvcLink}>

Go to PVC list

</Button>



</Trans>

afreen23 · 2021-04-06T06:38:34Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+                  <p>
+                    Deleting <strong>{state.poolName}</strong> will remove all the saved data of
+                    this pool. Are you sure want to delete?
+                  </p>


Suggested change



Deleting {state.poolName} will remove all the saved data of

this pool. Are you sure want to delete?



<Trans t={t} ns="ceph-storage-plugin">



Deleting {{state.poolName}} will remove all the saved data of

this pool. Are you sure want to delete?



</Trans>

afreen23 · 2021-04-06T06:38:44Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+                    this pool. Are you sure want to delete?
+                  </p>
+                )}
+              </Trans>


Suggested change

</Trans>

afreen23 · 2021-04-06T07:27:27Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+    (scNameList: string[]) => {
+      const pvcScNames = pvcResources?.items?.map((pvcConfig) => pvcConfig?.spec?.storageClassName);
+      // intersection of scNames and pvcScNames
+      const usedScNames = scNameList.filter((scName) => pvcScNames.includes(scName));
+      if (usedScNames.length) {
+        dispatch({ type: BlockPoolActionType.SET_POOL_STATUS, payload: POOL_PROGRESS.BOUNDED });
+        setScNames(usedScNames);
+      }
+    },
+    [pvcResources],
+  );
+
+  // find storage class using pool
+  React.useEffect(() => {
+    if (scLoaded && pvcLoaded)
+      checkPvcStatus(
+        scResources?.items
+          ?.filter((scConfig) => state.poolName === scConfig?.parameters?.pool)
+          .map((scConfig) => scConfig?.metadata?.name) || [],
+      );
+  }, [scResources, scLoaded, pvcResources, pvcLoaded, state.poolName, checkPvcStatus]);


You can find a lot of these helpers in selectors/index.ts . You can leverage those and you should always create pure functions is possible.
For instance -> getPVStorageClass for
const pvcScNames = pvcResources?.items?.map((pvcConfig) => pvcConfig?.spec?.storageClassName);
And set the state setScNames in useEffect

GowthamShanmugam · 2021-04-06T11:51:16Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

  onClick: () => void;
+  action: 'Create' | 'Save' | 'Delete';
+  onPoolCreation?: (name: string) => void;


this footer is shared by create | delete | update module so no more extra option required

GowthamShanmugam · 2021-04-06T11:52:45Z

@afreen23 Changes done

afreen23 · 2021-04-06T13:08:25Z

frontend/packages/ceph-storage-plugin/src/selectors/index.ts

+export const getPvcNames = (pvcResources: ListKind<K8sResourceKind>): string[] =>
+  pvcResources?.items?.map((pvcConfig) => getStorageClassName(pvcConfig));


Its giving you sc names and not pvc names.
No need to create a new utility just use it directly in the component as follows:

Suggested change

export const getPvcNames = (pvcResources: ListKind<K8sResourceKind>): string[] =>

pvcResources?.items?.map((pvcConfig) => getStorageClassName(pvcConfig));

const scNames = pvcResources?.items?.map(getStorageClassName);

afreen23 · 2021-04-06T13:31:21Z

frontend/packages/ceph-storage-plugin/src/selectors/index.ts

+export const getSCNamesUsingPool = (
+  scData: ListKind<K8sResourceKind>,
+  poolName: string,
+): string[] =>
+  scData.items?.reduce((scNames, sc) => {
+    if (_.get(sc, 'parameters.pool') === poolName) scNames.push(sc.metadata?.name);
+    return scNames;
+  }, []);


Do not put this here, if its not going to be used by components other than pool.

Suggested change

export const getSCNamesUsingPool = (

scData: ListKind<K8sResourceKind>,

poolName: string,

): string[] =>

scData.items?.reduce((scNames, sc) => {

if (_.get(sc, 'parameters.pool') === poolName) scNames.push(sc.metadata?.name);

return scNames;

}, []);

export const getSCNamesUsingPool = (

scData: ListKind<K8sResourceKind>,

poolName: string,

): string[] =>

scData.items?.reduce((scNames, sc) => {

if (sc?.parameters?.pool === poolName) scNames.push(sc.metadata?.name);

return scNames;

}, []);

Ah! got the point

afreen23 · 2021-04-06T13:37:55Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+      const pvcScNames: string[] = getPvcNames(pvcResources) || [];
+      // intersection of scNames and pvcScNames
+      const usedScNames = scNameList.filter((scName) => pvcScNames.includes(scName));
+      if (usedScNames.length) {
+        dispatch({ type: BlockPoolActionType.SET_POOL_STATUS, payload: POOL_PROGRESS.BOUNDED });
+        setScNames(usedScNames);
+      }
+    },


Here you can move this logic to use effect below itself.
You dont need callback since pvcResources is a dependency there as well. Hence not providing the expected optimization.

afreen23 · 2021-04-06T13:44:40Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

@@ -63,17 +63,20 @@ export const BlockPoolModalFooter = (props: BlockPoolModalFooterProps) => {
      </Button>
      <Button
        type="button"
-        variant="primary"
+        variant={action !== 'Delete' ? 'primary' : 'danger'}


Better to create an enum of all button texts.
Import and use pf ButtonVariant enum.

Suggested change

variant={action !== 'Delete' ? 'primary' : 'danger'}

variant={action !== ButtonText.Delete ? ButtonVariant.primary' : ButtonVariant.danger'}

GowthamShanmugam · 2021-04-06T18:01:50Z

/retest

afreen23 · 2021-04-06T19:30:22Z

frontend/packages/ceph-storage-plugin/src/selectors/index.ts

@@ -29,8 +29,8 @@ export const getCephPVs = (pvsData: K8sResourceKind[] = []): K8sResourceKind[] =
    );
  });

-const getPVStorageClass = (pv: K8sResourceKind) => _.get(pv, 'spec.storageClassName');
-const getStorageClassName = (pvc: K8sResourceKind) =>
+export const getPVStorageClass = (pv: K8sResourceKind) => _.get(pv, 'spec.storageClassName');


Suggested change

export const getPVStorageClass = (pv: K8sResourceKind) => _.get(pv, 'spec.storageClassName');

const getPVStorageClass = (pv: K8sResourceKind) => _.get(pv, 'spec.storageClassName');

afreen23 · 2021-04-06T19:31:40Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+      const pvcScNames: string[] = pvcResources.items?.map((pvcConfig) =>
+        getStorageClassName(pvcConfig),
+      );


Suggested change

const pvcScNames: string[] = pvcResources.items?.map((pvcConfig) =>

getStorageClassName(pvcConfig),

);

const pvcScNames: string[] = pvcResources.items?.map(getStorageClassName);

afreen23 · 2021-04-07T04:55:57Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+
+  React.useEffect(() => {
+    if (scLoaded && pvcLoaded && state.poolStatus !== POOL_PROGRESS.NOTALLOWED) {
+      const scNameList: string[] = scResources.items?.reduce((scList, sc) => {


Suggested change

const scNameList: string[] = scResources.items?.reduce((scList, sc) => {

const poolScNames: string[] = scResources.items?.reduce((scList, sc) => {

afreen23

Lets make the go to pvc list the primary action instead pf close, also add cancel.

afreen23 · 2021-04-07T09:10:13Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+                <p>
+                  <strong>{{ poolName }}</strong> cannot be deleted. When a pool is bounded to PVC
+                  it cannot be deleted. Please detach all the resources from storage class(es){' '}
+                  <strong>{{ scNames }}</strong>.{' '}


dont you want to destructure all array elements separated by comma and the last element by and?

i accidentally removed the change, let me check how to add and for last element

GowthamShanmugam · 2021-04-08T12:16:50Z

frontend/packages/ceph-storage-plugin/src/utils/common.ts

+
+export const commaSeparatedString = (text: string[], t: TFunction): string =>
+  [text.slice(0, -1).join(', '), text.slice(-1)[0]].join(
+    text.length < 2 ? '' : ` ${t('ceph-storage-plugin~and ')}`,


i uded ` ${t('ceph-storage-plugin~and ')}` is working

For translation, its better to not put any spaces with strings. Also there is a chance of accidental miss while modifying.
Also explicit indication of spaces misses the chance of removal while making any changes.

Suggested change

text.length < 2 ? '' : ` ${t('ceph-storage-plugin~and ')}`,

text.length < 2 ? '' : ` ${t('ceph-storage-plugin~and')} `,

GowthamShanmugam · 2021-04-08T18:17:57Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

+    ],
+    [POOL_PROGRESS.NOTREADY]: [
+      {
+        id: 'modal-finish-action',


few states have similar prop but i don't want to create a new function to pass the prop, I feel let it be separate, so we can do changes in future easily

afreen23 · 2021-04-08T12:30:09Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+              state={state}
+              dispatch={dispatch}
+              onClick={onClick}
+              redirectToPvcList={redirectToPvcList}


Ideally your footer should be generic to take two values vs onClick, redirect, actionTextButtonMapping.

onSubmit - for primary text

onCancel - for secondary text
I dont think you need an extra enum - actionTextButtonMapping

afreen23 · 2021-04-09T03:45:47Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

+        type: ButtonType.submit,
+        variant: ButtonVariant.primary,
+        onClick: () => {
+          redirectToPvcList();


Suggested change

redirectToPvcList();

history.push('/k8s/all-namespaces/persistentvolumeclaims');

afreen23 · 2021-04-09T03:48:03Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+    handlePromise(k8sKill(CephBlockPoolModel, blockPoolConfig), () => close());
+  };
+
+  const redirectToPvcList = () => {


What is the error you are getting ? I assume you can call it there too.

afreen23 · 2021-04-09T03:48:41Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

-  closeLabel: string;
+  actionButtonTextMapping: ActionButtonTextMapping;
+  confirmAction: () => void;
+  redirectToPvcList?: () => void;


Suggested change

redirectToPvcList?: () => void;

afreen23 · 2021-04-09T03:49:01Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

-    actionLabel,
-    closeLabel,
+    confirmAction,
+    redirectToPvcList,


Suggested change

redirectToPvcList,

afreen23 · 2021-04-09T04:10:00Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/update-block-pool-modal.tsx

              cancel={cancel}
              close={close}
-              actionLabel={t('ceph-storage-plugin~Save')}
-              closeLabel={t('ceph-storage-plugin~Close')}
+              actionButtonTextMapping={ActionButtonTextMapping.UPDATE}


Suggested change

actionButtonTextMapping={ActionButtonTextMapping.UPDATE}

primaryAction={FooterPrimaryActions.UPDATE}

afreen23 · 2021-04-09T04:11:04Z

frontend/packages/ceph-storage-plugin/src/types.ts

@@ -274,3 +276,9 @@ export type Payload = K8sResourceCommon & {
    [key: string]: any;
  };
 };
+
+export type OcsStorageClassResource = StorageClassResourceKind & {


Suggested change

export type OcsStorageClassResource = StorageClassResourceKind & {

export type OcsStorageClassKind = StorageClassResourceKind & {

afreen23 · 2021-04-09T04:11:30Z

frontend/packages/ceph-storage-plugin/src/utils/block-pool.tsx

@@ -208,3 +208,9 @@ export const checkRequiredValues = (
  volumeType: string,
  isPoolManagementSupported: boolean,
 ): boolean => !poolName || !replicaSize || (isPoolManagementSupported && !volumeType);
+
+export enum ActionButtonTextMapping {


Suggested change

export enum ActionButtonTextMapping {

export enum FooterPrimaryActions {

afreen23 · 2021-04-09T04:15:58Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

-      </Button>
-    </ActionGroup>
-  ) : (
+  const modalFooterButtonFactory: ModalFooterButtonFactory = {


Suggested change

const modalFooterButtonFactory: ModalFooterButtonFactory = {

const footerButtonsFactory: FooterButtonFactory = {

afreen23 · 2021-04-09T04:18:38Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

+        label: t('ceph-storage-plugin~Cancel'),
+        type: ButtonType.button,
+        variant: ButtonVariant.secondary,
+        onClick: () => cancel(),


Suggested change

onClick: () => cancel(),

onClick: cancel

GowthamShanmugam · 2021-04-09T06:34:07Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

 import { ModalComponentProps } from '@console/internal/components/factory/modal';
+import { history } from '@console/internal/components/utils/router';


it works after import history from the correct place

afreen23 · 2021-04-09T07:07:55Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/create-block-pool-modal.tsx

          cancel={props.cancel}
          close={props.close}
-          actionLabel={t('ceph-storage-plugin~Create')}
-          closeLabel={t('ceph-storage-plugin~Finish')}
+          footerPrimaryAction={FooterPrimaryActions.CREATE}


nit: since its footer component's prop

Suggested change

footerPrimaryAction={FooterPrimaryActions.CREATE}

primaryAction={FooterPrimaryActions.CREATE}

afreen23 · 2021-04-09T07:09:11Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+  }, [scResources, scLoaded, pvcResources, pvcLoaded, state.poolStatus, poolName, t]);
+
+  // Delete block pool
+  const onClick = () => {


Suggested change

const onClick = () => {

const deletePool = () => {

afreen23 · 2021-04-09T07:09:52Z

...kages/ceph-storage-plugin/src/components/modals/block-pool-modal/delete-block-pool-modal.tsx

+  kind?: string;
+  blockPoolConfig?: StoragePoolKind;


why all props optional ?

And I cant find where kind is used ?

Kind is optional as per extension design we have to receive both, but kind is optional

afreen23 · 2021-04-09T07:11:42Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

+};
+
+type ModalFooterButtonFactory = {
+  [stauts: string]: ButtonProps[];


Suggested change

[stauts: string]: ButtonProps[];

[status: POOL_PROGRESS]: ButtonProps[];

i think it should be status in POOL_PROGRESS

reason i used string is, i used default string

afreen23 · 2021-04-09T07:12:08Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

+  disable?: boolean;
+  onClick: (e?: React.FormEvent<EventTarget>) => void;


Suggested change

disable?: boolean;

onClick: (e?: React.FormEvent<EventTarget>) => void;

onClick: (e?: React.FormEvent<EventTarget>) => void;

disable?: boolean;

afreen23 · 2021-04-09T07:24:51Z

frontend/packages/ceph-storage-plugin/src/components/modals/block-pool-modal/modal-footer.tsx

-    cancel,
-    close,
-  } = props;
+  const { state, dispatch, onSubmit, footerPrimaryAction, cancel, close } = props;


Can't this footer be used for create block pool as well ?
Just to have one footer - BlockPoolFooter rather than one for modals and one for create.

I can but it needs some hack for alignment, l thought it will confuse others, anyway, let me think what I can do here

afreen23 · 2021-04-09T09:18:20Z

frontend/packages/ceph-storage-plugin/src/components/block-pool/footer.tsx

+};
+
+type FooterButtonFactory = {
+  [stauts in POOL_PROGRESS | 'default']?: ButtonProps[];


Suggested change

[stauts in POOL_PROGRESS | 'default']?: ButtonProps[];

[status in POOL_PROGRESS | 'default']?: ButtonProps[];

afreen23 · 2021-04-09T09:19:23Z

frontend/packages/ceph-storage-plugin/src/components/block-pool/footer.tsx

+  const actionContentAlign = (buttons: JSX.Element[]) =>
+    className.includes('actions--left') ? buttons.reverse() : buttons;


why reversing buttons order ?

afreen23 · 2021-04-09T09:25:24Z

frontend/packages/ceph-storage-plugin/src/components/block-pool/create-block-pool.tsx

+                cancel={onClose}
+                onSubmit={createPool}
+                primaryAction={FooterPrimaryActions.CREATE}
+                className="pf-c-form pf-c-form__actions--left"


why pf-c-form on button actions ?

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>

afreen23

/lgtm

openshift-ci-robot · 2021-04-09T11:28:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, GowthamShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [afreen23]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

GowthamShanmugam · 2021-04-09T12:27:54Z

/retest

GowthamShanmugam · 2021-04-09T12:28:54Z

/retest

openshift-bot · 2021-04-09T14:16:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

GowthamShanmugam · 2021-04-09T16:56:56Z

/retest

afreen23 · 2021-04-09T19:31:01Z

/test e2e-gcp-console

openshift-bot · 2021-04-09T19:55:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Apr 4, 2021

openshift-ci-robot requested review from afreen23 and rawagner April 4, 2021 13:56

GowthamShanmugam commented Apr 4, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch 2 times, most recently from 1d4d086 to 27dc27d Compare April 4, 2021 16:47

openshift-ci-robot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Apr 4, 2021

GowthamShanmugam force-pushed the pool_delete branch 5 times, most recently from c690455 to 0e7cf8c Compare April 5, 2021 13:28

afreen23 suggested changes Apr 6, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch 3 times, most recently from 41c0ff9 to 36e3168 Compare April 6, 2021 11:49

GowthamShanmugam commented Apr 6, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch from 36e3168 to 7d4bfaf Compare April 6, 2021 12:55

afreen23 suggested changes Apr 6, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch from 7d4bfaf to b6724c2 Compare April 6, 2021 15:17

afreen23 suggested changes Apr 7, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch 3 times, most recently from ddc7a5c to 92c06ce Compare April 7, 2021 08:43

afreen23 suggested changes Apr 7, 2021

View reviewed changes

GowthamShanmugam commented Apr 8, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch 4 times, most recently from 45c211f to 01856e4 Compare April 8, 2021 18:15

GowthamShanmugam commented Apr 8, 2021

View reviewed changes

afreen23 suggested changes Apr 9, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch from 01856e4 to 4958eb9 Compare April 9, 2021 06:31

GowthamShanmugam commented Apr 9, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch from 4958eb9 to 7ddb6dd Compare April 9, 2021 06:58

afreen23 suggested changes Apr 9, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch from 7ddb6dd to a7baaaf Compare April 9, 2021 09:12

afreen23 suggested changes Apr 9, 2021

View reviewed changes

GowthamShanmugam force-pushed the pool_delete branch from a7baaaf to 257b9a0 Compare April 9, 2021 10:41

Pool management - delete

3814595

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>

GowthamShanmugam force-pushed the pool_delete branch from 257b9a0 to 3814595 Compare April 9, 2021 11:11

afreen23 approved these changes Apr 9, 2021

View reviewed changes

openshift-ci-robot assigned afreen23 Apr 9, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2021

GowthamShanmugam mentioned this pull request Apr 9, 2021

Added plugin for delete block pool modal #8600

Merged

openshift-merge-robot merged commit b99922d into openshift:master Apr 10, 2021

spadgett added this to the v4.8 milestone May 10, 2021

		export const getPvcNames = (pvcResources: ListKind<K8sResourceKind>): string[] =>
		pvcResources?.items?.map((pvcConfig) => getStorageClassName(pvcConfig));

	export const getPvcNames = (pvcResources: ListKind<K8sResourceKind>): string[] =>
	pvcResources?.items?.map((pvcConfig) => getStorageClassName(pvcConfig));
	const scNames = pvcResources?.items?.map(getStorageClassName);

	variant={action !== 'Delete' ? 'primary' : 'danger'}
	variant={action !== ButtonText.Delete ? ButtonVariant.primary' : ButtonVariant.danger'}

	export const getPVStorageClass = (pv: K8sResourceKind) => _.get(pv, 'spec.storageClassName');
	const getPVStorageClass = (pv: K8sResourceKind) => _.get(pv, 'spec.storageClassName');

	const scNameList: string[] = scResources.items?.reduce((scList, sc) => {
	const poolScNames: string[] = scResources.items?.reduce((scList, sc) => {

	text.length < 2 ? '' : ` ${t('ceph-storage-plugin~and ')}`,
	text.length < 2 ? '' : ` ${t('ceph-storage-plugin~and')} `,

	redirectToPvcList();
	history.push('/k8s/all-namespaces/persistentvolumeclaims');

	actionButtonTextMapping={ActionButtonTextMapping.UPDATE}
	primaryAction={FooterPrimaryActions.UPDATE}

	export type OcsStorageClassResource = StorageClassResourceKind & {
	export type OcsStorageClassKind = StorageClassResourceKind & {

	export enum ActionButtonTextMapping {
	export enum FooterPrimaryActions {

	const modalFooterButtonFactory: ModalFooterButtonFactory = {
	const footerButtonsFactory: FooterButtonFactory = {

		import { ModalComponentProps } from '@console/internal/components/factory/modal';
		import { history } from '@console/internal/components/utils/router';

	footerPrimaryAction={FooterPrimaryActions.CREATE}
	primaryAction={FooterPrimaryActions.CREATE}

	[stauts: string]: ButtonProps[];
	[status: POOL_PROGRESS]: ButtonProps[];

		disable?: boolean;
		onClick: (e?: React.FormEvent<EventTarget>) => void;

	[stauts in POOL_PROGRESS \| 'default']?: ButtonProps[];
	[status in POOL_PROGRESS \| 'default']?: ButtonProps[];

		const actionContentAlign = (buttons: JSX.Element[]) =>
		className.includes('actions--left') ? buttons.reverse() : buttons;

Pool management - delete #8550

Pool management - delete #8550

Conversation

GowthamShanmugam commented Apr 4, 2021

Choose a reason for hiding this comment

GowthamShanmugam commented Apr 4, 2021 • edited Loading

GowthamShanmugam commented Apr 5, 2021

GowthamShanmugam commented Apr 5, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam commented Apr 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam commented Apr 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afreen23 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam Apr 8, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afreen23 left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Apr 9, 2021

GowthamShanmugam commented Apr 9, 2021

GowthamShanmugam commented Apr 9, 2021

openshift-bot commented Apr 9, 2021

GowthamShanmugam commented Apr 9, 2021

afreen23 commented Apr 9, 2021

openshift-bot commented Apr 9, 2021

GowthamShanmugam commented Apr 4, 2021 •

edited

Loading

GowthamShanmugam Apr 8, 2021 •

edited

Loading