Bug 1952635: fixes: Web console displays a blank page- white space instead of cluster information #8810
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@sahil143: This pull request references Bugzilla bug 1952635, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/cc @christianvogt |
| display: flex; | ||
| flex: 1 0 auto; | ||
| flex-direction: column; | ||
| height: 100% // doesn't work on safari without height |
There was a problem hiding this comment.
Definitely a solution... tested and it works on Safari 14.
Alternative would be to just set the child to a flex-grow: 1 to fill the page instead of this height.
There was a problem hiding this comment.
Did you test the solution in both desktop and mobile? I've encountered issues with the PF drawer on mobile.
I don't know which solution is best without further investigating myself.
So @andrewballantyne are you wanting this change to be made or not? Since you didn't give lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sahil143: All pull requests linked via external trackers have merged: Bugzilla bug 1952635 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR fixes the blank page issue with safari https://bugzilla.redhat.com/show_bug.cgi?id=1952635