Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1952635: fixes: Web console displays a blank page- white space instead of cluster information #8810

Merged
merged 1 commit into from Apr 29, 2021
Merged

Bug 1952635: fixes: Web console displays a blank page- white space instead of cluster information #8810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/public/components/app.jsx
View file
Open in desktop
Expand Up @@ -159,7 +159,7 @@ class App_ extends React.PureComponent {
<>
<Helmet titleTemplate={`%s · ${productName}`} defaultTitle={productName} />
<QuickStartDrawer>
<div id="app-content" className="co-m-page__body">
<div id="app-content" className="co-m-app__content">
<ConsoleNotifier location="BannerTop" />
<Page
header={<Masthead onNavToggle={this._onNavToggle} />}
Expand Down
7 changes: 7 additions & 0 deletions frontend/public/style/_layout.scss
View file
Open in desktop
Expand Up @@ -32,6 +32,13 @@ body,
flex-direction: column;
}

.co-m-app__content {
display: flex;
flex: 1 0 auto;
flex-direction: column;
height: 100% // doesn't work on safari without height
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a solution... tested and it works on Safari 14.

Alternative would be to just set the child to a flex-grow: 1 to fill the page instead of this height.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the solution in both desktop and mobile? I've encountered issues with the PF drawer on mobile.
I don't know which solution is best without further investigating myself.
So @andrewballantyne are you wanting this change to be made or not? Since you didn't give lgtm

}

.co-p-has-sidebar {
position: relative;
display: flex;
Expand Down