Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1957756: Fix key value in replacement object #8880

Merged
merged 1 commit into from May 14, 2021
Merged

Bug 1957756: Fix key value in replacement object #8880

merged 1 commit into from May 14, 2021

Conversation

afreen23
Copy link
Contributor

@afreen23 afreen23 commented May 10, 2021 •
edited

  • key is node but we are fetching nodeName.
  • removed the check for metrics map since it's redundant.
  • updated check for the replaced device based on path and deviceID to differentiate similar paths on same node

Signed-off-by: Afreen Rahman afrahman@redhat.com

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@afreen23: This pull request references Bugzilla bug 1957756, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request.

In response to this:

Bug 1957756: Remove extra layer of checking in disk list page status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bipuladh and rawagner May 10, 2021 18:26
@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@afreen23: This pull request references Bugzilla bug 1957756, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request.

In response to this:

Bug 1957756: Remove extra layer of checking in disk list page status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23 afreen23 changed the title Bug 1957756: Remove extra layer of checking in disk list page status Bug 1957756: Fix key value in replacement object May 10, 2021
bipuladh
bipuladh approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@afreen23
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@afreen23
Copy link
Contributor Author

Need to test out the fix for all test cases again

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2021

@afreen23: This pull request references Bugzilla bug 1957756, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request.

In response to this:

Bug 1957756: Fix key value in replacement object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23 afreen23 force-pushed the master branch 3 times, most recently from fe26137 to 7a48e31 Compare May 13, 2021 17:37
@afreen23
Copy link
Contributor Author

/hold cancel
tested with actual disks based environment. Working fine

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2021
@afreen23 afreen23 requested a review from bipuladh May 13, 2021 18:12
Bug 1957756: Fix key value in replacement object
55f1202 
- key is `node` but we are fetching `nodeName`.
- removed the check for metrics map since it's redundant.
- updated check for the replaced device based on osd, path, deviceID, serial and node combination.

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@afreen23
Copy link
Contributor Author

/test ceph-storage-plugin
/test e2e-gcp-console

@afreen23
Copy link
Contributor Author

/test e2e-gcp-console

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@afreen23: This pull request references Bugzilla bug 1957756, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request.

In response to this:

Bug 1957756: Fix key value in replacement object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5d9b4b8 into openshift:master May 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@afreen23: All pull requests linked via external trackers have merged:

Bugzilla bug 1957756 has been moved to the MODIFIED state.

In response to this:

Bug 1957756: Fix key value in replacement object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.8 milestone May 18, 2021
afreen23 pushed a commit to afreen23/console that referenced this pull request May 24, 2021
Bug 1957756: Missing already replaced condition in disk modal
e79b597 
The PR openshift#8880 added checking for a replaced disk but we missed out adding in disk replacemnet modal as well.
@afreen23 afreen23 mentioned this pull request May 24, 2021
Merged
afreen23 pushed a commit to afreen23/console that referenced this pull request May 24, 2021
Bug 1957756: Missing already replaced condition in disk modal
d7fd9b7 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
afreen23 pushed a commit to afreen23/console that referenced this pull request May 25, 2021
Bug 1957756: Missing already replaced condition in disk modal
f98f2ea 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
afreen23 pushed a commit to afreen23/console that referenced this pull request May 25, 2021
Bug 1957756: Missing already replaced condition in disk modal
a0788a1 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
afreen23 pushed a commit to afreen23/console that referenced this pull request May 25, 2021
Bug 1957756: Missing already replaced condition in disk modal
3b2127b 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
afreen23 pushed a commit to afreen23/console that referenced this pull request May 25, 2021
Bug 1957756: Missing already replaced condition in disk modal
0e072e0 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
afreen23 pushed a commit to afreen23/console that referenced this pull request May 25, 2021
Bug 1957756: Missing already replaced condition in disk modal
d8adc26 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
afreen23 pushed a commit to afreen23/console that referenced this pull request May 25, 2021
Bug 1957756: Missing already replaced condition in disk modal
bc9a395 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
afreen23 pushed a commit to afreen23/console that referenced this pull request May 26, 2021
Bug 1957756: Missing already replaced condition in disk modal
c1d4d0e 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
afreen23 pushed a commit to afreen23/console that referenced this pull request May 30, 2021
Bug 1957756: Missing already replaced condition in disk modal
5466486 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap

(cherry picked from commit c1d4d0e)
afreen23 pushed a commit to afreen23/console that referenced this pull request May 30, 2021
Bug 1957756: Missing already replaced condition in disk modal
3a0ca08 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap

(cherry picked from commit c1d4d0e)
afreen23 pushed a commit to afreen23/console that referenced this pull request May 30, 2021
Bug 1957756: Missing already replaced condition in disk modal
3a9de92 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap

(cherry picked from commit c1d4d0e)
afreen23 pushed a commit to afreen23/console that referenced this pull request May 31, 2021
Bug 1957756: Missing already replaced condition in disk modal
7c77210 
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap

(cherry picked from commit c1d4d0e)
@afreen23 afreen23 mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner Awaiting requested review from rawagner

@bipuladh bipuladh Awaiting requested review from bipuladh

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@afreen23 @bipuladh @spadgett @openshift-merge-robot