-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1957756: Fix key value in replacement object #8880
Conversation
@afreen23: This pull request references Bugzilla bug 1957756, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@afreen23: This pull request references Bugzilla bug 1957756, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
Need to test out the fix for all test cases again |
@afreen23: This pull request references Bugzilla bug 1957756, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fe26137
to
7a48e31
Compare
/hold cancel |
- key is `node` but we are fetching `nodeName`. - removed the check for metrics map since it's redundant. - updated check for the replaced device based on osd, path, deviceID, serial and node combination. Signed-off-by: Afreen Rahman <afrahman@redhat.com>
/test ceph-storage-plugin |
/test e2e-gcp-console |
@afreen23: This pull request references Bugzilla bug 1957756, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@afreen23: All pull requests linked via external trackers have merged: Bugzilla bug 1957756 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The PR openshift#8880 added checking for a replaced disk but we missed out adding in disk replacemnet modal as well.
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well.
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap (cherry picked from commit c1d4d0e)
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap (cherry picked from commit c1d4d0e)
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap (cherry picked from commit c1d4d0e)
The PR openshift#8880 added checking for a replaced disk in the list page but we missed out adding in disk replacemnet modal as well. When more templates are present for same disk then disk name cant be used, hence removed disk name usage in replacementMap (cherry picked from commit c1d4d0e)
node
but we are fetchingnodeName
.Signed-off-by: Afreen Rahman afrahman@redhat.com