Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1960545: Overly generic CSS rules for dd and dt elements breaks styling elsewhere in console #8926

Merged
merged 1 commit into from Jun 10, 2021
Merged

[release-4.6] Bug 1960545: Overly generic CSS rules for dd and dt elements breaks styling elsewhere in console #8926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 19 additions & 20 deletions .../packages/kubevirt-plugin/src/components/create-vm-wizard/tabs/review-tab/review-tab.scss
View file
Open in desktop
Expand Up @@ -23,30 +23,29 @@
grid-column-gap: var(--pf-global--spacer--2xl);
grid-row-gap: var(--pf-global--spacer--sm);
}
}

dt {
font-weight: var(--pf-global--FontWeight--semi-bold);

&:not(:first-child) {
margin-top: var(--pf-global--spacer--md);

dt {
font-weight: var(--pf-global--FontWeight--semi-bold);

&:not(:first-child) {
margin-top: var(--pf-global--spacer--md);

@media screen and (min-width: $pf-global--breakpoint--sm) {
margin-top: 0;
}
}

@media screen and (min-width: $pf-global--breakpoint--sm) {
margin-top: 0;
grid-column: 1;
}
}

@media screen and (min-width: $pf-global--breakpoint--sm) {
grid-column: 1;
}
}

dd {
@media screen and (min-width: $pf-global--breakpoint--sm) {
grid-column: 2;

dd {
@media screen and (min-width: $pf-global--breakpoint--sm) {
grid-column: 2;
}

margin: 0;
}

margin: 0;
}

.kubevirt-create-vm-modal__review-tab__footer {
Expand Down