Bug 1966275: Fix Pipeline Parameters in Modals accept empty string defaults

[andrewballantyne]

Slimmed down version of: #9074
(the functionality without the proper moving of the utility & type differences between the two releases)

[openshift-ci]

@andrewballantyne: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix Pipeline Parameters in Modals accept empty string defaults

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@andrewballantyne: This pull request references Bugzilla bug 1966275, which is invalid:

• expected the bug to target the "4.7.z" release, but it targets "4.7.0" instead
• expected dependent Bugzilla bug 1951043 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1966275: Fix Pipeline Parameters in Modals accept empty string defaults

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/bugzilla refresh

[openshift-ci]

@andrewballantyne: This pull request references Bugzilla bug 1966275, which is invalid:

• expected dependent Bugzilla bug 1951043 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/retest

[karthikjeeyar]

In 4.7, While starting the pipeline with no default param, it opens the start modal with start button enabled even if the user haven't entered any value. If user hasn't entered anything in required field, then start button should be disabled.

[andrewballantyne]

In 4.7, While starting the pipeline with no default param, it opens the start modal with start button enabled even if the user haven't entered any value. If user hasn't entered anything in required field, then start button should be disabled.

It seems to do nothing with my code (happens on 4.7 without my PR + with a more mirrored version of the 4.8 code), but I am unsure what actually is fixing this in 4.8. The yup errors are not catching value of undefined until you touch the param. 🤔

I think we are going to have to go with what this is. The issue predates my work here and isn't exposed anymore or less by my changes so I don't think it's worth anymore time to try and figure this out. If you have a better idea of what could be causing it @karthikjeeyar - I'd be happy to investigate more.

[andrewballantyne]

Thanks for the suggestion @karthikjeeyar - Completely forgot about that hook for Formik. It probably got implemented somewhere in this form for another reason in 4.8 and thus was solving the issues for the whole modal.

EDIT: Once I knew what I was looking for, sure enough that's it. 4.7 code vs 4.8 code (added in #8355)

[karthikjeeyar]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

[openshift-ci]

@openshift-bot: This pull request references Bugzilla bug 1966275, which is invalid:

• expected dependent Bugzilla bug 1951043 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

[openshift-ci]

@openshift-bot: This pull request references Bugzilla bug 1966275, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1951043 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1951043 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@andrewballantyne: All pull requests linked via external trackers have merged:

• openshift/console#9085

Bugzilla bug 1966275 has been moved to the MODIFIED state.

In response to this:

Bug 1966275: Fix Pipeline Parameters in Modals accept empty string defaults

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.