-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1966275: Fix Pipeline Parameters in Modals accept empty string defaults #9085
Bug 1966275: Fix Pipeline Parameters in Modals accept empty string defaults #9085
Conversation
@andrewballantyne: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andrewballantyne: This pull request references Bugzilla bug 1966275, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@andrewballantyne: This pull request references Bugzilla bug 1966275, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
In 4.7, While starting the pipeline with no default param, it opens the start modal with start button enabled even if the user haven't entered any value. If user hasn't entered anything in required field, then start button should be disabled. |
It seems to do nothing with my code (happens on 4.7 without my PR + with a more mirrored version of the 4.8 code), but I am unsure what actually is fixing this in 4.8. The I think we are going to have to go with what this is. The issue predates my work here and isn't exposed anymore or less by my changes so I don't think it's worth anymore time to try and figure this out. If you have a better idea of what could be causing it @karthikjeeyar - I'd be happy to investigate more. |
...ackages/pipelines-plugin/src/components/pipelines/modals/common/PipelineParameterSection.tsx
Show resolved
Hide resolved
cb574d1
to
24650c5
Compare
Thanks for the suggestion @karthikjeeyar - Completely forgot about that hook for Formik. It probably got implemented somewhere in this form for another reason in 4.8 and thus was solving the issues for the whole modal. EDIT: Once I knew what I was looking for, sure enough that's it. 4.7 code vs 4.8 code (added in #8355) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1966275, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1966275, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andrewballantyne: All pull requests linked via external trackers have merged: Bugzilla bug 1966275 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Slimmed down version of: #9074
(the functionality without the proper moving of the utility & type differences between the two releases)