Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly touch pipeline builder task fields when workspaces are changed #9130

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -14,7 +14,7 @@ import { EditorType } from '@console/shared/src/components/synced-editor/editor-
import { safeJSToYAML } from '@console/shared/src/utils/yaml';
import { PipelineKind, PipelineTask, TaskKind } from '../../../types';
import { PipelineModel } from '../../../models';
import { useFormikFetchAndSaveTasks } from './hooks';
import { useFormikFetchAndSaveTasks, useExplicitPipelineTaskTouch } from './hooks';
import { removeTaskModal } from './modals';
import PipelineBuilderHeader from './PipelineBuilderHeader';
import Sidebar from './task-sidebar/Sidebar';
Expand Down Expand Up @@ -60,6 +60,7 @@ const PipelineBuilderForm: React.FC<PipelineBuilderFormProps> = (props) => {
validateForm,
} = props;
useFormikFetchAndSaveTasks(namespace, validateForm);
useExplicitPipelineTaskTouch();

const statusRef = React.useRef(status);
statusRef.current = status;
Expand Down
@@ -1,7 +1,7 @@
import * as React from 'react';
import { useTranslation } from 'react-i18next';
import { getRandomChars } from '@console/shared';
import { useFormikContext } from 'formik';
import { useFormikContext, FormikTouched } from 'formik';
import { referenceForModel } from '@console/internal/module/k8s';
import { useK8sWatchResources } from '@console/internal/components/utils/k8s-watch-hook';
import { ClusterTaskModel, TaskModel } from '../../../models';
Expand Down Expand Up @@ -262,3 +262,40 @@ export const useNodes = (

return [...nodes, finallyNode];
};

const touchTaskWorkspaces = (task: PipelineTask): FormikTouched<PipelineTask> => ({
workspaces: task.workspaces?.map(() => ({ workspace: true })),
});

const touchTaskResources = (task: PipelineTask): FormikTouched<PipelineTask> => ({
resources: {
inputs: task.resources?.inputs?.map(() => ({ resource: true })),
outputs: task.resources?.outputs?.map(() => ({ resource: true })),
},
});

export const useExplicitPipelineTaskTouch = () => {
const { setTouched, touched, values } = useFormikContext<PipelineBuilderFormikValues>();
const workspacesTouched = !!touched.formData?.workspaces;
const resourcesTouched = !!touched.formData?.resources;

React.useEffect(() => {
if (workspacesTouched) {
setTouched({
formData: {
tasks: values.formData?.tasks?.map(touchTaskWorkspaces),
finallyTasks: values.formData?.finallyTasks?.map(touchTaskWorkspaces),
},
});
}
if (resourcesTouched) {
setTouched({
formData: {
tasks: values.formData?.tasks?.map(touchTaskResources),
finallyTasks: values.formData?.finallyTasks?.map(touchTaskResources),
},
});
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [workspacesTouched, resourcesTouched]);
};