Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1964902 improve display of network policies #9157

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Bug 1964902 improve display of network policies #9157

merged 1 commit into from
Jun 17, 2021

Conversation

jotak
Copy link
Contributor

@jotak jotak commented Jun 7, 2021

  • Show ipblock exceptions
  • Show all ipblocks in the same row within a rule
  • Specific text when podSelector is missing
  • JS->TS: create NetworkPolicyKind, more typing in network-policy.tsx

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jun 7, 2021
@jotak
Copy link
Contributor Author

jotak commented Jun 7, 2021

cc @yapei

  • Multiple IPBlocks in a row:

Capture d’écran de 2021-06-07 13-51-44

  • IPBlock exceptions in tooltip:

Capture d’écran de 2021-06-07 13-51-48

@jotak
Bug 1964902 improve display of network policies
3ac3466 
- Show ipblock exceptions
- Show all ipblocks in the same row within a rule
- Specific text when podSelector is missing
- JS->TS: create NetworkPolicyKind, more typing in network-policy.tsx
@yapei
Copy link
Contributor

yapei commented Jun 8, 2021

tested the changes in cluster-bot cluster, now everything looks good

@jotak
Copy link
Contributor Author

jotak commented Jun 10, 2021

/retest

@jotak
Copy link
Contributor Author

jotak commented Jun 16, 2021

@jhadvig @jeff-phillips-18 this was tested, now waiting for code review

jhadvig
jhadvig approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done 👍
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 95eedc3 into openshift:master Jun 17, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jotak @yapei @jhadvig @spadgett @openshift-merge-robot