Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1969386: deprecated metric kubevirt_vmi_storage_traffic_bytes_total #9182

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jun 8, 2021

Prometheus metrics deprecated:
kubevirt_vmi_storage_traffic_bytes_total is now kubevirt_vmi_storage_write_traffic_bytes_total and kubevirt_vmi_storage_read_traffic_bytes_total

Screenshot:
Before:
screenshot-localhost_9000-2021 06 08-20_42_54

After:
screenshot-localhost_9000-2021 06 08-20_42_00

Signed-off-by: yaacov kobi.zamir@gmail.com

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@yaacov: This pull request references Bugzilla bug 1969386, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1969386: deprecated metric kubevirt_vmi_storage_traffic_bytes_total

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci openshift-ci bot requested review from rhrazdil and suomiy June 8, 2021 17:44
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 8, 2021
@yaacov
Copy link
Member Author

yaacov commented Jun 8, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@yaacov: This pull request references Bugzilla bug 1969386, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2021
@openshift-ci openshift-ci bot requested a review from gouyang June 8, 2021 17:44
@yaacov
Copy link
Member Author

yaacov commented Jun 8, 2021

@glekner @pcbailey @metalice please review

@metalice
Copy link
Contributor

metalice commented Jun 8, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@yaacov: This pull request references Bugzilla bug 1969386, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1969386: deprecated metric kubevirt_vmi_storage_traffic_bytes_total

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
Signed-off-by: yaacov <kobi.zamir@gmail.com>
@yaacov yaacov force-pushed the depracted-storage-traffic-metrics branch from 4e4cf0b to 05545fb Compare June 8, 2021 18:39
@openshift-ci openshift-ci bot added kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated and removed lgtm Indicates that a PR is ready to be merged. labels Jun 8, 2021
@kyoto
Copy link
Member

kyoto commented Jun 9, 2021

FYI @openshift/openshift-team-monitoring

@yaacov
Copy link
Member Author

yaacov commented Jun 9, 2021

/retest

@avivtur
Copy link
Contributor

avivtur commented Jun 9, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor

lgtm from a monitoring perspective

@yaacov
Copy link
Member Author

yaacov commented Jun 9, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7d99b44 into openshift:master Jun 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

@yaacov: All pull requests linked via external trackers have merged:

Bugzilla bug 1969386 has been moved to the MODIFIED state.

In response to this:

Bug 1969386: deprecated metric kubevirt_vmi_storage_traffic_bytes_total

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.8 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants