Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example placeholder for labels section of odc add flows #9269

Merged
merged 1 commit into from Jun 24, 2021
Merged

Update example placeholder for labels section of odc add flows #9269

merged 1 commit into from Jun 24, 2021

Conversation

divyanshiGupta
Copy link
Contributor

@divyanshiGupta divyanshiGupta commented Jun 16, 2021 •
edited

Fixes: https://issues.redhat.com/browse/ODC-6027

This PR updates example placeholder for labels section as app label can be misleading for the users since it is a default label and hence is added always when an app is created using add flows and also since only user-labels are editable via edit flows.

Screenshot:
Screenshot 2021-06-16 at 5 54 22 PM

cc: @openshift/team-devconsole-ux

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 16, 2021
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jun 16, 2021
@divyanshiGupta
Copy link
Contributor Author

/assign @rohitkrai03

@divyanshiGupta
Copy link
Contributor Author

divyanshiGupta commented Jun 16, 2021 •
edited

@beaumorley PTAL at this PR. I have updated the label placeholder to be app.io/type=frontend if that looks fine to you can you add your approval ?

rohitkrai03
rohitkrai03 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Code changes looks good to me. Will wait for UX to approve the placeholder text itself.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@beaumorley
Copy link

I am not an expert in the syntax. If the syntax is correct, from UX POV it looks good. Thanks.

@nemesis09
Copy link
Contributor

/retest

@nemesis09
Copy link
Contributor

verified locally
has approval from UX for the changes.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, nemesis09, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d72bbcf into openshift:master Jun 24, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@nemesis09 nemesis09 Awaiting requested review from nemesis09

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rohitkrai03 rohitkrai03

@nemesis09 nemesis09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@divyanshiGupta @beaumorley @nemesis09 @openshift-bot @rohitkrai03 @spadgett @openshift-merge-robot