Bug 1970604: Add IDP menu items are not translated #9308
Conversation
|
@cyril-ui-developer: This pull request references Bugzilla bug 1970604, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-low
|
@cyril-ui-developer: This pull request references Bugzilla bug 1970604, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@cyril-ui-developer: This pull request references Bugzilla bug 1970604, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| return ( | ||
| <DropdownItem | ||
| key={`idp-${addIDPItems[idp]}`} |
There was a problem hiding this comment.
@rhamilto @rebeccaalpert I am not sure why we were assigning addIDPItems object value here. I think it should be the key.
| // t('public~Keystone') | ||
| // t('public~LDAP') | ||
| // t('public~OpenID Connect') | ||
| // t('public~Request Header') |
There was a problem hiding this comment.
@rhamilto @rebeccaalpert I think we don't need the above any more.
There was a problem hiding this comment.
You're totally right; we don't need these anymore.
|
LGTM but will wait for @rebeccaalpert to give the final approval as the resident i18n expert. :) |
| // t('public~Keystone') | ||
| // t('public~LDAP') | ||
| // t('public~OpenID Connect') | ||
| // t('public~Request Header') |
There was a problem hiding this comment.
You're totally right; we don't need these anymore.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyril-ui-developer, rebeccaalpert, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
|
@cyril-ui-developer: This pull request references Bugzilla bug 1970604, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@rhamilto: This pull request references Bugzilla bug 1970604, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cyril-ui-developer: All pull requests linked via external trackers have merged: Bugzilla bug 1970604 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rhamilto
cc: @rebeccaalpert