Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temp branding override #933

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Remove temp branding override #933

merged 1 commit into from
Feb 24, 2019

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Dec 11, 2018 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2018
@spadgett
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2018
spadgett
spadgett reviewed Dec 11, 2018
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we want to hold off changing the branding for the moment for the developer preview

@alecmerdler
Copy link
Contributor

/test backend

@spadgett
Copy link
Member

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 21, 2019
@spadgett
Copy link
Member

/retest

1 similar comment
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

s2i test flake

/retest

@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit b2a2e13 into openshift:master Feb 24, 2019
@rhamilto rhamilto deleted the branding-rollback branch February 25, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

Assignees

@spadgett spadgett

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhamilto @spadgett @alecmerdler @openshift-ci-robot @openshift-merge-robot