CONSOLE-2838: masthead changes to better align with ACM

[rhamilto]

#9508 includes the about modal changes since those depend on ACM changes that are still under development.

Changes in this PR:

• If ACM is installed, ACM Documentation is added to the help menu
• Remove the padding override around the username dropdown toggle as it is no longer needed

[spadgett]

Thanks, @rhamilto.

[rhamilto]

/hold for approvals

/assign @spadgett @ahardin-rh @sferich888 @yapei

[spadgett]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

@rhamilto @yapei It will be hard for QE to verify the ACM documentation link since we haven't merged the operator and backend changes for the ACM integration. We could simply confirm there are no regressions.

@yapei You might be able to set window.SERVER_FLAGS.clusters = ['foo','bar'] in the browser JS console to test the link.

[yapei]

The ACM operator installation is blocked(always in Pending status) due to legacy apiVersion in CRD (tracked in https://bugzilla.redhat.com/show_bug.cgi?id=1981227 )

Under this circumstance, I did

1. Created consolelink/acm-console resource manually and it has following spec

apiVersion: console.openshift.io/v1
kind: ConsoleLink
metadata:
  name: acm-console-link
spec:
  applicationMenu:
    imageURL: https://CONSOLE_ROUTE/multicloud/header/graphics/RHACM-logo_24x24.svg
    section: Red Hat Applications
  href: https://CONSOLE_ROUTE
  location: ApplicationMenu
  text: Red Hat Advanced Cluster Management for Kubernetes

2. Set window.SERVER_FLAGS.clusters = ['foo','bar'] in browser JS console

At last, we check the Advanced Cluster Management appears in perspective dropdown(regression) and ACM Documentation link is shown in Helper dropdown list, clicking it will redirect to https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes//

[yapei]

no user visible changes for the _overrides.scss update, no issues found.
Let me know if I'm testing wrongly
/label qe-approved

[rhamilto]

@yapei, step 2 is the relevant one for the changes in this PR. You can do step 1, but nothing in the PR will impact the application launcher.

[rhamilto]

no user visible changes for the _overrides.scss update, no issues found.

You should see the user dropdown toggle shift left.

Screen.Recording.2021-07-15.at.8.52.04.AM.mov

[ahardin-rh]

/label docs-approved

[yapei]

no user visible changes for the _overrides.scss update, no issues found.

You should see the user dropdown toggle shift left.
Screen.Recording.2021-07-15.at.8.52.04.AM.mov

Thank you!

[rhamilto]

@sferich888, please review as this PR is awaiting px-approved.

[sferich888]

/label px-approved
/unassign @sferich888

[spadgett]

/hold cancel

[rhamilto]

/retest

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.