Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2838: masthead changes to better align with ACM #9396

Merged
merged 1 commit into from Jul 23, 2021
Merged

CONSOLE-2838: masthead changes to better align with ACM #9396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions frontend/public/components/masthead-toolbar.jsx
View file
Open in desktop
Expand Up @@ -24,6 +24,7 @@ import { FLAGS, YellowExclamationTriangleIcon, ACM_LINK_ID } from '@console/shar
import { formatNamespacedRouteForResource } from '@console/shared/src/utils';
import CloudShellMastheadButton from '@console/app/src/components/cloud-shell/CloudShellMastheadButton';
import CloudShellMastheadAction from '@console/app/src/components/cloud-shell/CloudShellMastheadAction';
import isMultiClusterEnabled from '@console/app/src/utils/isMultiClusterEnabled';
import * as UIActions from '../actions/ui';
import { connectToFlags } from '../reducers/connectToFlags';
import { flagPending, featureReducerName } from '../reducers/features';
Expand Down Expand Up @@ -327,6 +328,20 @@ class MastheadToolbarContents_ extends React.Component {
fireTelemetryEvent('Documentation Clicked');
},
},
...(isMultiClusterEnabled()
? [
{
label: t('public~ACM Documentation'),
externalLink: true,
// TODO: add version number to end of URL
href:
'https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes',
callback: () => {
fireTelemetryEvent('ACM Documentation Clicked');
},
},
]
: []),
...(flags[FLAGS.CONSOLE_CLI_DOWNLOAD]
? [
{
Expand Down
1 change: 1 addition & 0 deletions frontend/public/locales/en/public.json
View file
Open in desktop
Expand Up @@ -640,6 +640,7 @@
"Red Hat applications": "Red Hat applications",
"Quick Starts": "Quick Starts",
"Documentation": "Documentation",
"ACM Documentation": "ACM Documentation",
"Command line tools": "Command line tools",
"About": "About",
"Language preference": "Language preference",
Expand Down
6 changes: 0 additions & 6 deletions frontend/public/style/_overrides.scss
View file
Open in desktop
Expand Up @@ -129,12 +129,6 @@ h6 {
font-family: $font-family-base;
}

// Temp fix to adjust user menu dropdown toggle padding until it can be converted back to a standard dropdown
.co-user-menu .pf-c-app-launcher__toggle {
padding-left: 0;
padding-right: 0;
}

.pf-c-breadcrumb {
padding-bottom: 12px;
padding-top: 25px;
Expand Down